Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): Node18 support #564

Merged
merged 1 commit into from
Oct 6, 2022
Merged

fix(api): Node18 support #564

merged 1 commit into from
Oct 6, 2022

Conversation

aaronpowell
Copy link
Contributor

With the recent release of support for Node 18 in the Functions v4 runtime, we should update the tools check code to allow that.

@github-actions github-actions bot added the scope: core Issues happened a the ./src/core level label Sep 16, 2022
@aaronpowell aaronpowell changed the title Node18 support for Functions v4 fix(api): Node18 support Sep 16, 2022
@sgollapudi77 sgollapudi77 mentioned this pull request Sep 23, 2022
Open
2 tasks
@sgollapudi77 sgollapudi77 added the status: need internal approval The issue need an internal approval from a stakeholder before it gets addressed label Sep 23, 2022
@sgollapudi77 sgollapudi77 mentioned this pull request Sep 26, 2022
Closed
@sulabh-msft sulabh-msft removed the status: need internal approval The issue need an internal approval from a stakeholder before it gets addressed label Sep 26, 2022
@sgollapudi77 sgollapudi77 merged commit d24df7a into Azure:main Oct 6, 2022
@xxnickles
Copy link

Is this really supported? Just tried on Windows 11 (nodejs lts 18.12.1) and it cannot connect to the API endpoint (I am using the bring your functions approach with a function 4 project) However, swa works just find in node 16 (I had to downgrade my install). Am I missing anything here?

@aaronpowell aaronpowell deleted the node-18-support branch November 6, 2022 23:02
@aaronpowell
Copy link
Contributor Author

Assuming you're using the 1.0.3 release of SWA CLI it should be there

@xxnickles
Copy link

Assuming you're using the 1.0.3 release of SWA CLI it should be there

I am using 1.0.3. Even though there are no explicit errors related to the nodejs version as there were in previous versions, the proxy is just not able to connect to the functions project when using node 18 lts ( ✖ Could not connect to "http://localhost:7071". Is the server up and running?) but works with node 16. I tried several times upgrading/downgrading and I have got the same results (at least in windows 11, I need to check it on fedora) Are you aware of any specific conditions (like having to use preview sdk for functions) to work with swa cli and node js 18? Just for additional piece information, I am using Blazor + dotnet functions

@xxnickles xxnickles mentioned this pull request Nov 8, 2022
Open
sgollapudi77 added a commit that referenced this pull request Dec 19, 2022
@sgollapudi77
Squashed commit of the following:
267519c 
commit 02fdb90
Author: Yohan Lasorsa <[email protected]>
Date:   Fri Dec 16 10:09:48 2022 +0100

    fix: --api-devserver-url not working if --api-location not set (#523, #579) (#620)

    * fix: --api-devserver-url not working if --api-location not set (#523, #579)

    * docs: fix documentation regarding --api-devserver-url usage (#579)

commit 7ecbae2
Author: Reshmi Sriram <[email protected]>
Date:   Thu Dec 15 13:10:12 2022 +0530

    docs: Add firewall section to troubleshoot (#618)

    * Added firewall section

    * updated the message

commit eee1263
Author: BeardinaSuit <[email protected]>
Date:   Sun Dec 11 23:54:32 2022 -0500

    fix: handle new provider name when deploying (#617)

commit 27ec687
Author: Stuart Leeks <[email protected]>
Date:   Tue Dec 6 09:40:07 2022 +0000

    Fix typo (#605)

    fix: typo in CONTRIBUTING.md

commit 9c43aa8
Author: Stuart Leeks <[email protected]>
Date:   Tue Dec 6 09:38:51 2022 +0000

    Update title (#606)

    docs: In the doc content this is referred to as the "configuration file" and this feels like a more natural title

commit 97e9461
Merge: 08ac26c ac6909a
Author: Rupa Reddy <[email protected]>
Date:   Tue Dec 6 13:06:18 2022 +0530

    Merge pull request #614 from Azure/origin/rupareddy/LoginCC

    fix(login): fixed short-form of --clear-credentials flag

commit 08ac26c
Merge: 2cd0e98 6d1ad19
Author: Rupa Reddy <[email protected]>
Date:   Tue Dec 6 12:59:29 2022 +0530

    Merge pull request #613 from Azure/origin/rupareddy/FixRGName

    fix(deploy): create SWA in user-provided Resource Group

commit 6d1ad19
Author: rupareddy5 <[email protected]>
Date:   Mon Dec 5 14:57:37 2022 +0530

    fix: to fix the inability to create a SWA in user-mentioned resource group, changed all the resourceGroupName references to resourceGroup in the code to match with --resource-group flag.

commit ac6909a
Author: rupareddy5 <[email protected]>
Date:   Mon Dec 5 13:34:00 2022 +0530

    fixed short-form of --clear-credentials flag

commit ca856be
Author: rupareddy5 <[email protected]>
Date:   Fri Dec 2 16:17:38 2022 +0530

    create SWA in user-provided Resource Group

commit 2cd0e98
Author: sgollapudi77 <[email protected]>
Date:   Wed Nov 9 11:32:46 2022 +0530

    chore: upgrade dependency version to fix security vulnerability (#597)

    * chore: upgrade dependency version to fix security vulnerability

    * chore: upgrade integrity of package

commit 3bdc5f1
Author: sgollapudi77 <[email protected]>
Date:   Sun Oct 9 16:34:22 2022 +0530

    chore: bump into 1.0.4-alpha after release (#586)

commit 5ab32a7
Merge: b4fbf3a a6f08e3
Author: Sulabh Upadhyay <[email protected]>
Date:   Fri Oct 7 14:15:35 2022 +0530

    Merge pull request #585 from Azure/all-contributors/add-rupareddy5-21

    docs: add rupareddy5-21 as a contributor for code

commit a6f08e3
Author: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Date:   Fri Oct 7 08:20:26 2022 +0000

    docs: update .all-contributorsrc

commit b461129
Author: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Date:   Fri Oct 7 08:20:25 2022 +0000

    docs: update docs/www/docs/contribute/3-contributors.md

commit b4fbf3a
Author: sgollapudi77 <[email protected]>
Date:   Fri Oct 7 12:51:28 2022 +0530

    ci: Remove Node 12 from the testing matrix (#584)

commit 4b0114b
Author: sgollapudi77 <[email protected]>
Date:   Fri Oct 7 12:01:04 2022 +0530

    chore: prep-release 1.0.3 (#583)

commit 4af9624
Author: Wassim Chegham <[email protected]>
Date:   Fri Oct 7 07:30:23 2022 +0200

    docs: update troubleshooting with explainer #576 (#581)

commit 70c126e
Author: Wassim Chegham <[email protected]>
Date:   Fri Oct 7 07:30:03 2022 +0200

    docs: add valid azure regions for SWA (#582)

    * docs: add valid azure regions for SWA

    * docs: update azure regions

commit 6004141
Author: Wassim Chegham <[email protected]>
Date:   Thu Oct 6 08:52:36 2022 +0200

    fix(core): match * glob in routes (#574)

    Fixes #569

commit d24df7a
Author: Aaron Powell <[email protected]>
Date:   Thu Oct 6 17:51:46 2022 +1100

    fix(api): bumping the node support to 18 for v4 functions (#564)

commit 1fec77e
Merge: 19c619b 2771906
Author: Rupa Reddy <[email protected]>
Date:   Thu Oct 6 11:38:36 2022 +0530

    Merge pull request #577 from rupareddy5-21/main

    Updating deployment provider

commit 2771906
Author: Rupa Reddy <[email protected]>
Date:   Thu Sep 29 16:34:22 2022 +0530

    Updating Deployment provider

commit 1b7fabd
Author: Rupa Reddy <[email protected]>
Date:   Thu Sep 29 16:33:02 2022 +0530

    updating Deployment provider

commit 19c619b
Author: Natalia Venditto <[email protected]>
Date:   Mon Sep 26 15:13:12 2022 +0200

    docs: add default port for vite-based frameworks (#571)

commit 47823b0
Merge: 06356c1 7e021c7
Author: Sulabh Upadhyay <[email protected]>
Date:   Fri Sep 16 15:05:06 2022 +0530

    Merge pull request #560 from Azure/swa-start-perf-boost

    fix(start): keep connection open with http-proxy

commit 06356c1
Author: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Date:   Wed Sep 14 23:10:22 2022 +0530

    docs: add thsackos as a contributor (#561)

    * docs: update docs/www/docs/contribute/3-contributors.md

    * docs: update .all-contributorsrc

    Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

commit 8b7d725
Author: thsackos <[email protected]>
Date:   Wed Sep 14 06:13:25 2022 -0700

    fix(cli): implement missing response override referrer behavior (#543)

    The documentation calls out user-defined redirect behavior using the
    .referrer parameter in the response override configuration. This PR
    enables the SWA CLI emulator to support that functionality.

    Fixes #542

commit 7e021c7
Author: Wassim Chegham <[email protected]>
Date:   Wed Sep 14 12:19:03 2022 +0200

    fix(start): keep connection open with http-proxy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgollapudi77 sgollapudi77 sgollapudi77 approved these changes

@sulabh-msft sulabh-msft sulabh-msft approved these changes

@manekinekko manekinekko manekinekko approved these changes

@sinedied sinedied sinedied approved these changes

Assignees
No one assigned
Labels
scope: core Issues happened a the ./src/core level
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aaronpowell @xxnickles @sinedied @manekinekko @sulabh-msft @sgollapudi77