JwtSecurityTokenConverter initial commit #2117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keegan-caruso
requested review from
brentschmaltz,
jmprieur,
jennyf19 and
westin-m
westin-m
reviewed
Jun 20, 2023
test/System.IdentityModel.Tokens.Jwt.Tests/JwtSecurityTokenConverterTests.cs
Outdated
Show resolved
Hide resolved
westin-m
reviewed
Jun 20, 2023
test/System.IdentityModel.Tokens.Jwt.Tests/JwtSecurityTokenConverterTests.cs
Outdated
Show resolved
Hide resolved
westin-m
reviewed
Jun 20, 2023
test/System.IdentityModel.Tokens.Jwt.Tests/JwtSecurityTokenConverterTests.cs
Outdated
Show resolved
Hide resolved
jennyf19
reviewed
Jun 20, 2023
jennyf19
reviewed
Jun 20, 2023
src/System.IdentityModel.Tokens.Jwt/JwtSecurityTokenConverter.cs
Outdated
Show resolved
Hide resolved
jennyf19
reviewed
Jun 20, 2023
| return new JwtSecurityToken(header, payload); | ||
| } | ||
|
|
||
| throw new ArgumentException("token.EncodedToken or token.Header and token.Payload must be set"); |
westin-m
approved these changes
Jun 20, 2023
keegan-caruso
force-pushed
the
kecaruso/json-jwt-ctor
branch
from
a630cc9
to
55da154
Compare
src/System.IdentityModel.Tokens.Jwt/JwtSecurityTokenConverter.cs
Outdated
Show resolved
Hide resolved
| { | ||
| return new JwtSecurityToken(token.EncodedToken); | ||
| } | ||
| else if (token.Header != null && token.Payload != null) |
There was a problem hiding this comment.
If we fix the bug where JsonWebToken.EncodedToken is never null, we will not need this.
Also, you could write: new JwtSecurityToken(token.EncodedHeader + "." token.EncodedPayload + ".")
Wilson bug: #2065
There was a problem hiding this comment.
Believe this is addressed, @brentschmaltz what do you think?
keegan-caruso
force-pushed
the
kecaruso/json-jwt-ctor
branch
from
6dc0356
to
98140dc
Compare
brentschmaltz
pushed a commit
that referenced
this pull request
Jul 25, 2023
Co-authored-by: Keegan Caruso <[email protected]>
brentschmaltz
pushed a commit
that referenced
this pull request
Jul 28, 2023
Co-authored-by: Keegan Caruso <[email protected]>
brentschmaltz
pushed a commit
that referenced
this pull request
Sep 6, 2023
Co-authored-by: Keegan Caruso <[email protected]>
brentschmaltz
pushed a commit
that referenced
this pull request
Sep 7, 2023
Co-authored-by: Keegan Caruso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.