Compatibility with 6x for bool claims #2367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix behavior where ToString is used on bool values resulting in the value being True/False instead of true/false
jmprieur
approved these changes
Oct 16, 2023
ciaozhang
approved these changes
Oct 16, 2023
jennyf19
approved these changes
Oct 16, 2023
jennyf19
pushed a commit
that referenced
this pull request
Jan 9, 2024
Compatibility with 6x for bool claims (#2367) * Compatibility with 6x for bool claims Fix behavior where ToString is used on bool values resulting in the value being True/False instead of true/false * Use direct ClaimValueType --------- Co-authored-by: Keegan Caruso <[email protected]> ---- #### AI-Generated Description The pull request modifies the handling of boolean claims in the JsonWebToken library. It changes the encoding and decoding of boolean values to use lowercase "true" and "false" instead of uppercase "True" and "False". It also adds unit tests to verify the expected behavior. The main changes are in the following files: - **JsonWebTokenTests.cs**: Adds a new test method `BoolClaimsEncodedAsExpected` to check the encoding and decoding of boolean claims. - **JwtPayload.cs**: Adds logic to handle boolean values in the `CreateClaims` and `CreateClaimFromObject` methods. - **JsonClaimSet.cs**: Adds logic to handle boolean values in the `CreateClaimFromObject` and `CreateClaimFromJsonElement` methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix behavior where ToString is used on bool values resulting in the value being True/False instead of true/false
Description
restores previous behavior for bool claims
Fixes #2354