Replace AssemblyVersion with Version #2494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmprieur
approved these changes
Feb 23, 2024
There was a problem hiding this comment.
Thanks @FuPingFranco
This looks good.
I think you can still update the github flow, and remove the pack.ps1 script and the buildconfiguration.xml file.
Did you update the process?
I updated the github flow and created a separate task to look into all scripts post this changes. Also, working on documentation on the process and will share it asap. Thank you for all the help @jmprieur :) |
jmprieur
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace dependency on updateAssemblyInfo.ps1 with Version property and ADO variables. In order to bring our build and release experience across our repos to a unified process, we need to adopt the way versioning is done our other repos.
Test runs:
WisonVersion = ' ' (https://identitydivision.visualstudio.com/IDDP/_build/results?buildId=1257450&view=artifacts&pathAsName=false&type=publishedArtifacts )
WisonVersion = 7.3.3-preview-test-123 (https://identitydivision.visualstudio.com/IDDP/_build/results?buildId=1257449&view=artifacts&pathAsName=false&type=publishedArtifacts)
WisonVersion = 7.3.3 (https://identitydivision.visualstudio.com/IDDP/_build/results?buildId=1257451&view=artifacts&pathAsName=false&type=publishedArtifacts)
Fixes #2393