Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor XML comments for clarity in Microsoft.IdentityModel.JsonWebTokens and Microsoft.IdentityModel.Protocols.OpenIdConnect #2677

Merged
merged 9 commits into from
Jul 1, 2024

Conversation

joegoldman2
Copy link
Contributor

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • If any gains or losses in performance are possible, you've included benchmarks for your changes. More info
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Description

Continuation of #2676. This PR enhances the XML documentation across Microsoft.IdentityModel.Protocols.JsonWebTokens.

@joegoldman2 joegoldman2 requested a review from a team as a code owner June 29, 2024 18:49
@keegan-caruso keegan-caruso changed the title Refactor XML comments for clarity in Microsoft.IdentityModel.JsonWebTokens Refactor XML comments for clarity in Microsoft.IdentityModel.JsonWebTokens and Microsoft.IdentityModel.Protocols.OpenIdConnect Jun 30, 2024
@keegan-caruso
Copy link
Contributor

@joegoldman2 This is close, can you fix the error shown in CI and then we can take this.

Copy link
Contributor

@keegan-caruso keegan-caruso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@keegan-caruso keegan-caruso merged commit 612008a into AzureAD:dev Jul 1, 2024
3 checks passed
@joegoldman2 joegoldman2 deleted the xml-doc-jwt branch July 1, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants