Add request count and duration telemetry #3022

westin-m · 2024-11-20T21:55:54Z

Addresses client telemetry repair item

Add counter for get configuration requests and histogram for total duration of the same requests.

src/Microsoft.IdentityModel.Logging/IdentityModelTelemetryUtil.cs

…zure-activedirectory-identitymodel-extensions-for-dotnet into westin/clientTelemetry

src/Microsoft.IdentityModel.Protocols/Configuration/ConfigurationManager.cs

build/dependenciesTest.props

src/Microsoft.IdentityModel.Logging/IdentityModelTelemetryUtil.cs

build/dependencies.props

src/Microsoft.IdentityModel.Logging/IdentityModelTelemetry.cs

src/Microsoft.IdentityModel.Logging/IdentityModelTelemetryUtil.cs

src/Microsoft.IdentityModel.Logging/WatchUtility.cs

src/Microsoft.IdentityModel.Protocols/Configuration/ConfigurationManager.cs

.../Microsoft.IdentityModel.Protocols.OpenIdConnect.Tests/ConfigurationManagerTelemetryTests.cs

src/Microsoft.IdentityModel.Protocols/Configuration/ConfigurationManager.cs

src/Microsoft.IdentityModel.Logging/IdentityModelTelemetryUtil.cs

src/Microsoft.IdentityModel.JsonWebTokens/JsonWebTokenHandler.ValidateToken.cs

src/Microsoft.IdentityModel.Logging/ConfigurationManagerTelemetryInstrumentation.cs

src/Microsoft.IdentityModel.Protocols/Configuration/ConfigurationManager.cs

src/Microsoft.IdentityModel.Logging/TelemetryConstants.cs

brentschmaltz

Asking for layering changes.

src/System.IdentityModel.Tokens.Jwt/JwtSecurityTokenHandler.cs

src/Microsoft.IdentityModel.Protocols/Configuration/ConfigurationManager.cs

src/Microsoft.IdentityModel.Logging/Microsoft.IdentityModel.Logging.csproj

src/Microsoft.IdentityModel.Tokens/Telemetry/IdentityModelTelemetry.cs

src/Microsoft.IdentityModel.Tokens/Telemetry/ITelemetryInstrumentation.cs

brentschmaltz

Some naming.
Code should live in assembly where dependencies are included.
Why do we need an interface?

src/Microsoft.IdentityModel.Tokens/Telemetry/TelemetryConstants.cs

src/Microsoft.IdentityModel.Tokens/Telemetry/IdentityModelTelemetry.cs

src/Microsoft.IdentityModel.Tokens/Telemetry/TelemetryInstrumentation.cs

src/Microsoft.IdentityModel.Tokens/Telemetry/TelemetryConstants.cs

src/Microsoft.IdentityModel.Protocols/Configuration/ConfigurationManager.cs

test/Microsoft.IdentityModel.JsonWebTokens.Tests/JsonWebTokenHandlerTelemetryTests.cs

src/Microsoft.IdentityModel.Tokens/Telemetry/IdentityModelTelemetry.cs

github-actions · 2025-01-06T21:00:12Z

Summary


Generated on:	1/6/2025 - 9:00:11 PM
Coverage date:	1/6/2025 - 8:50:27 PM - 1/6/2025 - 8:59:44 PM
Parser:	MultiReport (60x Cobertura)
Assemblies:	1
Classes:	7
Files:	2
Line coverage:	80.3% (620 of 772)
Covered lines:	620
Uncovered lines:	152
Coverable lines:	772
Total lines:	483
Branch coverage:	67.8% (228 of 336)
Covered branches:	228
Total branches:	336
Method coverage:	Feature is only available for sponsors

Coverage

Microsoft.IdentityModel.JsonWebTokens - 80.3%

Name	Line	Branch
Microsoft.IdentityModel.JsonWebTokens	80.3%	67.8%
Microsoft.IdentityModel.JsonWebTokens.JwtTokenUtilities	100%
System.Text.RegularExpressions.Generated	80.3%	67.8%
System.Text.RegularExpressions.Generated	80.3%	67.8%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F12A1AEDDDFE32BA DF4DBFF323AF1BCB48B9F9721B7CD3E05F5E034CF225E3DF8__CreateJweRegex_1	79.2%	68%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F12A1AEDDDFE32BA DF4DBFF323AF1BCB48B9F9721B7CD3E05F5E034CF225E3DF8__CreateJwsRegex_0	81.4%	67.6%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F334844C618E00D3 CEC5D3FE0D00CF0141BBEE98635313BB2CB8D3921464CE05A__CreateJweRegex_1	79.2%	68%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F334844C618E00D3 CEC5D3FE0D00CF0141BBEE98635313BB2CB8D3921464CE05A__CreateJwsRegex_0	81.4%	67.6%

github-actions · 2025-01-07T16:38:07Z

Summary


Generated on:	1/7/2025 - 4:38:06 PM
Coverage date:	1/7/2025 - 4:28:47 PM - 1/7/2025 - 4:37:40 PM
Parser:	MultiReport (60x Cobertura)
Assemblies:	1
Classes:	7
Files:	2
Line coverage:	80.3% (620 of 772)
Covered lines:	620
Uncovered lines:	152
Coverable lines:	772
Total lines:	483
Branch coverage:	67.8% (228 of 336)
Covered branches:	228
Total branches:	336
Method coverage:	Feature is only available for sponsors

Coverage

Microsoft.IdentityModel.JsonWebTokens - 80.3%

Name	Line	Branch
Microsoft.IdentityModel.JsonWebTokens	80.3%	67.8%
Microsoft.IdentityModel.JsonWebTokens.JwtTokenUtilities	100%
System.Text.RegularExpressions.Generated	80.3%	67.8%
System.Text.RegularExpressions.Generated	80.3%	67.8%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F12A1AEDDDFE32BA DF4DBFF323AF1BCB48B9F9721B7CD3E05F5E034CF225E3DF8__CreateJweRegex_1	79.2%	68%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F12A1AEDDDFE32BA DF4DBFF323AF1BCB48B9F9721B7CD3E05F5E034CF225E3DF8__CreateJwsRegex_0	81.4%	67.6%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F334844C618E00D3 CEC5D3FE0D00CF0141BBEE98635313BB2CB8D3921464CE05A__CreateJweRegex_1	79.2%	68%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F334844C618E00D3 CEC5D3FE0D00CF0141BBEE98635313BB2CB8D3921464CE05A__CreateJwsRegex_0	81.4%	67.6%

src/Microsoft.IdentityModel.Tokens/Telemetry/IdentityModelTelemetry.cs

src/Microsoft.IdentityModel.Tokens/Telemetry/TelemetryClient.cs

Co-authored-by: Keegan <[email protected]>

github-actions · 2025-01-07T21:17:24Z

Summary


Generated on:	1/7/2025 - 9:17:22 PM
Coverage date:	1/7/2025 - 9:08:15 PM - 1/7/2025 - 9:16:57 PM
Parser:	MultiReport (60x Cobertura)
Assemblies:	1
Classes:	7
Files:	2
Line coverage:	80.3% (620 of 772)
Covered lines:	620
Uncovered lines:	152
Coverable lines:	772
Total lines:	483
Branch coverage:	67.8% (228 of 336)
Covered branches:	228
Total branches:	336
Method coverage:	Feature is only available for sponsors

Coverage

Microsoft.IdentityModel.JsonWebTokens - 80.3%

Name	Line	Branch
Microsoft.IdentityModel.JsonWebTokens	80.3%	67.8%
Microsoft.IdentityModel.JsonWebTokens.JwtTokenUtilities	100%
System.Text.RegularExpressions.Generated	80.3%	67.8%
System.Text.RegularExpressions.Generated	80.3%	67.8%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F12A1AEDDDFE32BA DF4DBFF323AF1BCB48B9F9721B7CD3E05F5E034CF225E3DF8__CreateJweRegex_1	79.2%	68%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F12A1AEDDDFE32BA DF4DBFF323AF1BCB48B9F9721B7CD3E05F5E034CF225E3DF8__CreateJwsRegex_0	81.4%	67.6%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F334844C618E00D3 CEC5D3FE0D00CF0141BBEE98635313BB2CB8D3921464CE05A__CreateJweRegex_1	79.2%	68%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F334844C618E00D3 CEC5D3FE0D00CF0141BBEE98635313BB2CB8D3921464CE05A__CreateJwsRegex_0	81.4%	67.6%

github-actions · 2025-01-07T22:12:44Z

Summary


Generated on:	1/7/2025 - 10:12:44 PM
Coverage date:	1/7/2025 - 10:02:50 PM - 1/7/2025 - 10:12:17 PM
Parser:	MultiReport (60x Cobertura)
Assemblies:	1
Classes:	7
Files:	2
Line coverage:	80.3% (620 of 772)
Covered lines:	620
Uncovered lines:	152
Coverable lines:	772
Total lines:	483
Branch coverage:	67.8% (228 of 336)
Covered branches:	228
Total branches:	336
Method coverage:	Feature is only available for sponsors

Coverage

Microsoft.IdentityModel.JsonWebTokens - 80.3%

Name	Line	Branch
Microsoft.IdentityModel.JsonWebTokens	80.3%	67.8%
Microsoft.IdentityModel.JsonWebTokens.JwtTokenUtilities	100%
System.Text.RegularExpressions.Generated	80.3%	67.8%
System.Text.RegularExpressions.Generated	80.3%	67.8%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F12A1AEDDDFE32BA DF4DBFF323AF1BCB48B9F9721B7CD3E05F5E034CF225E3DF8__CreateJweRegex_1	79.2%	68%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F12A1AEDDDFE32BA DF4DBFF323AF1BCB48B9F9721B7CD3E05F5E034CF225E3DF8__CreateJwsRegex_0	81.4%	67.6%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F334844C618E00D3 CEC5D3FE0D00CF0141BBEE98635313BB2CB8D3921464CE05A__CreateJweRegex_1	79.2%	68%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F334844C618E00D3 CEC5D3FE0D00CF0141BBEE98635313BB2CB8D3921464CE05A__CreateJwsRegex_0	81.4%	67.6%

brentschmaltz

Suggest putting telemetry code in M.IM.Logging assembly.

github-actions · 2025-01-14T23:57:11Z

Summary


Generated on:	1/14/2025 - 11:57:10 PM
Coverage date:	1/14/2025 - 11:47:21 PM - 1/14/2025 - 11:56:45 PM
Parser:	MultiReport (60x Cobertura)
Assemblies:	1
Classes:	7
Files:	2
Line coverage:	80.3% (620 of 772)
Covered lines:	620
Uncovered lines:	152
Coverable lines:	772
Total lines:	483
Branch coverage:	67.8% (228 of 336)
Covered branches:	228
Total branches:	336
Method coverage:	Feature is only available for sponsors

Coverage

Microsoft.IdentityModel.JsonWebTokens - 80.3%

Name	Line	Branch
Microsoft.IdentityModel.JsonWebTokens	80.3%	67.8%
Microsoft.IdentityModel.JsonWebTokens.JwtTokenUtilities	100%
System.Text.RegularExpressions.Generated	80.3%	67.8%
System.Text.RegularExpressions.Generated	80.3%	67.8%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F12A1AEDDDFE32BA DF4DBFF323AF1BCB48B9F9721B7CD3E05F5E034CF225E3DF8__CreateJweRegex_1	79.2%	68%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F12A1AEDDDFE32BA DF4DBFF323AF1BCB48B9F9721B7CD3E05F5E034CF225E3DF8__CreateJwsRegex_0	81.4%	67.6%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F334844C618E00D3 CEC5D3FE0D00CF0141BBEE98635313BB2CB8D3921464CE05A__CreateJweRegex_1	79.2%	68%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F334844C618E00D3 CEC5D3FE0D00CF0141BBEE98635313BB2CB8D3921464CE05A__CreateJwsRegex_0	81.4%	67.6%

This reverts commit 9e91a64.

* Add request count and duration telemetry * Add request count and duration telemetry * small fix * Feedback, remodel timing and counters * Use interface for logging, move constants to class * some interface changes, rework tests * fix naming * address interface feedback * Interface and namespace changes * avoid friend assemblies * add metadata * doc comments for tags * PR feedback * Apply suggestions from code review Co-authored-by: Keegan <[email protected]> * change class name and add clarifying comments * Change namespace, move package reference --------- Co-authored-by: George Krechar <[email protected]> Co-authored-by: jennyf19 <[email protected]> Co-authored-by: Keegan <[email protected]>

Add request count and duration telemetry

c5e5d91

westin-m linked an issue Nov 20, 2024 that may be closed by this pull request

Add metadata request time to client telemetry #3023

Closed

westin-m commented Nov 20, 2024

View reviewed changes

src/Microsoft.IdentityModel.Logging/IdentityModelTelemetryUtil.cs Outdated Show resolved Hide resolved

westin-m added 2 commits November 21, 2024 14:58

Add request count and duration telemetry

c8bdbdf

Merge branch 'westin/clientTelemetry' of https://github.com/AzureAD/a…

f08864b

…zure-activedirectory-identitymodel-extensions-for-dotnet into westin/clientTelemetry

westin-m marked this pull request as ready for review November 21, 2024 23:05

westin-m requested a review from a team as a code owner November 21, 2024 23:05

Merge branch 'dev' into westin/clientTelemetry

2a739a3

westin-m changed the title ~~Add request count and duration telemetry DRAFT~~ Add request count and duration telemetry Nov 21, 2024

westin-m added 2 commits November 21, 2024 15:31

small fix

49790e3

Merge branch 'westin/clientTelemetry' of https://github.com/AzureAD/a…

ebc0740

…zure-activedirectory-identitymodel-extensions-for-dotnet into westin/clientTelemetry

brentschmaltz reviewed Nov 22, 2024

View reviewed changes

src/Microsoft.IdentityModel.Protocols/Configuration/ConfigurationManager.cs Outdated Show resolved Hide resolved