Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Update ID.Web.TokenCache to provide telemetry data during authentication. #4137

Closed
trwalke opened this issue May 17, 2023 · 5 comments
Assignees

Comments

@trwalke
Copy link
Member

trwalke commented May 17, 2023

Is your feature request related to a problem? Please describe.
ID.Web needs to provide telemetry data outlined in TelemetryData.cs.

Describe the solution you'd like
today, the only data available in TelemetryData.cs is the cache level which represents whether or not the cache used is L1 or L2. TelemetryData is exposed in the TokenCacheNotificationArgs` provided during cache operations. ID.Web needs to provide this telemetry data if available.

Additional context
Telemetry PR with the TelemetryData data type: #3737

@jmprieur
Copy link
Contributor

@trwalke should this be transferred in the Id.Web repo?

@jennyf19
Copy link
Collaborator

+1 to @jmprieur 's question. Also, can we see an example of the data from kusto? Is this part of the current telemetry being sent with msalCur/msalLast or something else? If part of current telemetry, do you have a link to the update in the ADO repo of the telemetry schema?

@bgavrilMS bgavrilMS changed the title [Feature Request] Update ID.Web to provide telemetry data during authentication. [Feature Request] Update ID.Web.TokenCache to provide telemetry data during authentication. May 18, 2023
@bgavrilMS
Copy link
Member

Agreed this should be moved to Id.Web repo for tracking. We can use a simple card (non-issue) to track progress on the MSAL.NET board.

@jennyf19 - this is the client telemetry, not HTTP telemetry, although it would be interesting to see this in HTTP telemetry as well, but not sure how to log it.

Epic is tracked with - #3784 and spec for client telemetry is here

@pmaytak
Copy link
Contributor

pmaytak commented May 19, 2023

There were issues already created:
#3596
AzureAD/microsoft-identity-web#1900
AzureAD/microsoft-identity-web#1901

@trwalke
Copy link
Member Author

trwalke commented May 24, 2023

AzureAD/microsoft-identity-web#2256

@trwalke trwalke moved this from In Progress to Waiting for Code Review in MSAL Customer Trust / QM Jun 1, 2023
@bgavrilMS bgavrilMS moved this from Waiting for Code Review to In Progress in MSAL Customer Trust / QM Jun 5, 2023
@trwalke trwalke moved this from In Progress to Waiting for Code Review in MSAL Customer Trust / QM Jun 7, 2023
@bgavrilMS bgavrilMS moved this from Waiting for Code Review to Blocked/Waiting for reply in MSAL Customer Trust / QM Jun 13, 2023
@github-project-automation github-project-automation bot moved this from Blocked/Waiting for reply to Fixed in MSAL Customer Trust / QM Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

5 participants