Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Telemetry client with data outlined in spec #3737

Merged
merged 38 commits into from
May 23, 2023

Conversation

neha-bhargava
Copy link
Contributor

@neha-bhargava neha-bhargava commented Oct 6, 2022

Fixes #3596, fixes #4119.

Changes proposed in this request

  • Add a placeholder for datapoints in TokenCacheNotificationArgs. These values will be populated when cache access is done in Microsoft.Identity.Web.
  • Log the data points to telemetry pipeline.

Testing

Performance impact

Documentation

  • All relevant documentation is updated.

Copy link
Member

@bgavrilMS bgavrilMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming is only blocking change, code looks ok otherwise with minor changes suggested.

@neha-bhargava
Copy link
Contributor Author

Removed the CacheUsed variable as this can be inferred as:

if (L2Latency > 0) 
    CacheUsed = L2
else 
    CacheUsed = L1

@pmaytak pmaytak self-requested a review October 26, 2022 05:25
@trwalke
Copy link
Member

trwalke commented May 3, 2023

cc @neha-bhargava for one final look

Copy link
Member

@bgavrilMS bgavrilMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with comments.

@neha-bhargava - can you please also show Travis how you tested this E2E so that we can see some values in Kusto ? Some manual validation would be great.

@bgavrilMS
Copy link
Member

@trwalke - please create a work item on ID.Web to track the work in the cache project.

# Conflicts:
#	tests/Microsoft.Identity.Test.Integration.netfx/HeadlessTests/PoPTests.cs
#	tests/Microsoft.Identity.Test.Unit/PublicApiTests/ConfidentialClientApplicationTests.cs
@trwalke trwalke enabled auto-merge (squash) May 23, 2023 05:41
@trwalke trwalke merged commit c99a106 into main May 23, 2023
@trwalke trwalke deleted the nebharg/AddCacheDetailsTelemetry branch May 23, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants