Service Fabric MSI #729
Merged
Service Fabric MSI #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgavrilMS
reviewed
Oct 18, 2023
msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/ManagedIdentityClient.java
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Oct 18, 2023
msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/ServiceFabricManagedIdentitySource.java
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Oct 18, 2023
msal4j-sdk/src/test/java/com/microsoft/aad/msal4j/ManagedIdentityTests.java
Outdated
Show resolved
Hide resolved
bgavrilMS
requested changes
Oct 18, 2023
msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/ServiceFabricManagedIdentitySource.java
Show resolved
Hide resolved
neha-bhargava
approved these changes
Oct 18, 2023
neha-bhargava
requested changes
Oct 18, 2023
…osoft-authentication-library-for-java into avdunn/service_fabric # Conflicts: # msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/ManagedIdentityClient.java # msal4j-sdk/src/test/java/com/microsoft/aad/msal4j/ManagedIdentityTests.java
bgavrilMS
approved these changes
Oct 20, 2023
…thentication-library-for-java into avdunn/service_fabric
neha-bhargava
approved these changes
Nov 7, 2023
Avery-Dunn
added a commit
that referenced
this pull request
Nov 9, 2023
* Add azure arc managed identity * Removed lenient from mock and merge conflicts * Clear cache in unit tests * Fix after manual testing * Update the log message * Service Fabric MSI (#729) * Support for service fabric, most tests working * TODOs and sonarlint recommendations * Address PR comments --------- Co-authored-by: Avery-Dunn <[email protected]> Co-authored-by: Avery-Dunn <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for Service Fabric and corresponding MSI unit tests.