Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed the DI pattern for Token Acquisition interfaces. #258

Merged
merged 1 commit into from
Jun 27, 2020
Merged

Changed the DI pattern for Token Acquisition interfaces. #258

merged 1 commit into from
Jun 27, 2020

Conversation

pmaytak
Copy link
Contributor

@pmaytak pmaytak commented Jun 25, 2020

Issue #240

@pmaytak pmaytak marked this pull request as ready for review June 26, 2020 19:47
jennyf19
jennyf19 approved these changes Jun 27, 2020
View reviewed changes
Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@pmaytak pmaytak merged commit f3fa25b into master Jun 27, 2020
@jmprieur jmprieur deleted the pmaytak/tokenAcqDI branch June 27, 2020 17:58
jmprieur added a commit that referenced this pull request Jun 29, 2020
@jmprieur @pmaytak @jennyf19
Jmprieur/related to249 (#271)
1593428 
* Changed the DI pattern for Token Acquisition interfaces. (#258)

* Update src/Microsoft.Identity.Web/ServiceCollectionExtensions.cs

Co-authored-by: jennyf19 <[email protected]>

Co-authored-by: pmaytak <[email protected]>
Co-authored-by: jennyf19 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennyf19 jennyf19 jennyf19 approved these changes

@jmprieur jmprieur Awaiting requested review from jmprieur

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmaytak @jennyf19