Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding CIAM E2E tests and improvements to build infrastructure #2753

Merged
merged 60 commits into from
Apr 17, 2024

Conversation

bgavrilMS
Copy link
Member

@bgavrilMS bgavrilMS commented Apr 11, 2024

Adding CIAM E2E tests and improvements to build infrastructure

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Description

CIAM tests

  • Webapp calls web api local

  • Web app calls web api (graph) disabled on the ADO for now. will be revisited(The entire file is disabled, not just this test)

Improvements to the YAML files

  • ID Web now has separate tasks for Building and running tests (One for unit tests, integration tests and E2E tests)

  • Separating these tasks should make it easier to onboard to Onebranch if we run into issues getting E2E tests running on the OneBranch agents.

  • ID Web can now leverage the test rerun feature in the VSTest ADO task to rerun failed tests. This will help improve overall test reliability.

  • Added logic to enable E2E tests to attempt a restart process restart a few times when it crashes prematurely. This should further improve reliability for the E2E tests

  • Screenshots are now captured when E2E Ui tests fail and are uploaded to the build run.

Fixes #{bug number} (in this specific format)

Continuation of #2728

@trwalke trwalke changed the title Trwalke/UI testing ciam Adding CIAM E2E tests and improvements to build infrastructure Apr 12, 2024
@bgavrilMS
Copy link
Member Author

I can't approve it because I opened the PR. Signing off.

This reverts commit b7622cd.
@trwalke
Copy link
Member

trwalke commented Apr 12, 2024

I can't approve it because I opened the PR. Signing off.

I can approve for you :). Still need a second approval

@trwalke trwalke marked this pull request as ready for review April 12, 2024 18:55
Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address piushing tests and coveragev to ado as before

@bgavrilMS bgavrilMS requested a review from a team as a code owner April 15, 2024 20:39
Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @trwalke

Once merged, you will need to cherry-pick to the rel/v2 branch too.

build/template-run-unit-tests.yaml Show resolved Hide resolved
@trwalke trwalke merged commit 43c622b into master Apr 17, 2024
5 checks passed
@trwalke trwalke deleted the trwalke/UiTestingCiam branch April 17, 2024 06:27
trwalke added a commit that referenced this pull request Apr 17, 2024
* Adding web app and web app call web api CIAM non CUD tests

* Adding CIAM deamon test app for non CUD domain

* Integrating lab client apps
Refactoring

* Refactoring

* Setting ui test to headless

* Update WebAppCallsApiCallsGraphLocally.cs

* Adding CIAM CUD integration tests (#2737)

* Adding CIAM CUD tests

* Updating comments

* Updating test

---------

Co-authored-by: trwalke <[email protected]>

* Enabling test runs with VSTest

* Test updates

* test

* Testing

* Disabling test

* Test

* Updating the CIAM tests to use the lab API (manual testing)

* Revert "Test"

This reverts commit c3f3d3a.

* Revert "Disabling test"

This reverts commit 5f2a384.

* Using hosted agents

* Always publish traces

* Revert "Using hosted agents"

This reverts commit 7484c58.

* Updating process error

* Publish screenshots

* Updating tests

* Adding additional statements

* Updating screenshot staging

* Fix typo

* Updating endpoint to use Http

* Reconfiguring ports

* hiding UI

* Enabling web app tests

* Resolving test issue

* Fixing run time and hiding ui

* Adding asp auth

* Enabling test

* Refactoring test YAML

* Disabling restore

* Fixing build task

* Test

* Test

* Fixing parameters

* Unit tests

* Install test platform

* Changing test runner

* Updating test directories

* Updating test run

* Fix typo

* Updating test run

* Updating check

* Refactoring process restart logic

* Clean up YAML

* Revert "Adding asp auth"

This reverts commit b7622cd.

* Refactoring

* Enabling code coverage settings

* Fix indentation

---------

Co-authored-by: trwalke <[email protected]>
Co-authored-by: Travis Walker <[email protected]>
Co-authored-by: Jean-Marc Prieur <[email protected]>
jennyf19 pushed a commit that referenced this pull request Apr 17, 2024
#2769)

* Adding web app and web app call web api CIAM non CUD tests

* Adding CIAM deamon test app for non CUD domain

* Integrating lab client apps
Refactoring

* Refactoring

* Setting ui test to headless

* Update WebAppCallsApiCallsGraphLocally.cs

* Adding CIAM CUD integration tests (#2737)

* Adding CIAM CUD tests

* Updating comments

* Updating test

---------



* Enabling test runs with VSTest

* Test updates

* test

* Testing

* Disabling test

* Test

* Updating the CIAM tests to use the lab API (manual testing)

* Revert "Test"

This reverts commit c3f3d3a.

* Revert "Disabling test"

This reverts commit 5f2a384.

* Using hosted agents

* Always publish traces

* Revert "Using hosted agents"

This reverts commit 7484c58.

* Updating process error

* Publish screenshots

* Updating tests

* Adding additional statements

* Updating screenshot staging

* Fix typo

* Updating endpoint to use Http

* Reconfiguring ports

* hiding UI

* Enabling web app tests

* Resolving test issue

* Fixing run time and hiding ui

* Adding asp auth

* Enabling test

* Refactoring test YAML

* Disabling restore

* Fixing build task

* Test

* Test

* Fixing parameters

* Unit tests

* Install test platform

* Changing test runner

* Updating test directories

* Updating test run

* Fix typo

* Updating test run

* Updating check

* Refactoring process restart logic

* Clean up YAML

* Revert "Adding asp auth"

This reverts commit b7622cd.

* Refactoring

* Enabling code coverage settings

* Fix indentation

---------

Co-authored-by: Bogdan Gavril <[email protected]>
Co-authored-by: trwalke <[email protected]>
Co-authored-by: Jean-Marc Prieur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants