Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ITokenAcquisition.GetAuthenticationResultForUserAsync #553

Merged
merged 7 commits into from
Sep 8, 2020

Conversation

jmprieur
Copy link
Collaborator

@jmprieur jmprieur commented Sep 5, 2020

Fixes #543:

  • small refactoring of the methods to return
    an AuthenticationResult instead of the token only
  • GetAccessTokenForUserAsync implemented based
    on GetAuthenticationResultForUserAsync

This was requested 3 times by partners this week (and discussed with @henrik-me during my 1:1 yesterday)

- small refactoring of the methods to return
  an AuthenticationResult instead of the token only
- GetAccessTokenForUserAsync implemented based
  on GetAuthenticationResultForUserAsync
- small refactoring of the methods to return
  an AuthenticationResult instead of the token only
- GetAccessTokenForUserAsync implemented based
  on GetAuthenticationResultForUserAsync
Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jmprieur jmprieur merged commit a830b03 into master Sep 8, 2020
@jmprieur jmprieur deleted the jmprieur/GetAuthenticationResultForUserAsync branch September 8, 2020 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] ITokenAcquisition should have extra methods to expose AuthenticationResult
2 participants