Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update spawn management commands / functionality #32

Merged
merged 8 commits into from
Jan 16, 2024
Merged

Update spawn management commands / functionality #32

merged 8 commits into from
Jan 16, 2024

Conversation

B3none
Copy link
Owner

@B3none B3none commented Jan 15, 2024

No description provided.

zwolof
zwolof reviewed Jan 15, 2024
View reviewed changes
Copy link
Collaborator

@zwolof zwolof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this just create yet another function that calls another function?
Might want to rethink the IsInRange method, is it really necessary?

zwolof
zwolof reviewed Jan 15, 2024
View reviewed changes
Copy link
Collaborator

@zwolof zwolof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of just throwing an error at them that they can't remove a spawn unless they're showing the spawns, you could show the spawns so they don't have to execute two commands to do one thing.
Just a UX improvement

zwolof
zwolof reviewed Jan 15, 2024
View reviewed changes
Copy link
Collaborator

@zwolof zwolof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice

@B3none B3none merged commit 9d2ea11 into master Jan 16, 2024
2 checks passed
@B3none B3none deleted the update-spawn-management-commands branch January 16, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zwolof zwolof zwolof left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@B3none @zwolof