Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add some notes to investigate modernizing our find_package logic
Historically we've created and bundled a lot of Find*.cmake files to allow find_package to locate our dependencies, but modern CMake has shifted towards packages providing *Config.cmake files in specific locations to avoid the need for such files. Some of bundled dependencies already do this, so we should be using those files when present. Looks like asset import library, png and proj are the current candidates. Probably should also investigate patching our bundled copies of libraries to provide such files, in the cases where they don't already do so. zlib in particular would most likely benefit from this, since we use custom naming and currently have to patch a large number of dependencies to teach them how to look for our version. If CMake doesn't have a built in way to look for a package and vanilla upstream doesn't provide export targets we'll still need to keep some Find*.cmake files for those cases, but we should strive to minimze them since it's looking like the exported target approach will be simpler and cleaner for bundled libs.
- Loading branch information