-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with navigation #12
Conversation
On my machine, at least, the menus still look different between the mediawiki and the landing page, is that intended? |
The only difference that's intended is the new logo and the lack of icons. I will use an icon font (instead of the current approach of using images) in next request so that will be settled. If there's any other difference give me a screenshot, and I will check. Thanks for taking a look. |
Hmm, interesting. I see a few other differences here as well: the font is different (sans serif vs. serif, and slightly bigger), and the community/blog items on the wiki are news/support on the main page. Can you reproduce those, or do you need screenshots? |
I think I know what's happening but I would still need screenshots just to be sure. |
Ah, okay, that makes sense. In that case, this looks good to me, except for the community/blog vs. news/support difference in the actual items. |
Okay, I am merging this to keep moving forward. If there are any issues, we can easily revert as I haven't completely thrown away the code for previous navigation. |
Compatibility with navigation
Coming late to the discussion, but I think this needs a bit more work. I like how the menu persists during scrolling, but I find the initial landing page impression less appealing now than the previous rendition. There's a stylistic imbalance and de-emphasis of the menu due to the decreased menu and font sizing. What I think we need is to blend both concepts. I suggest we start with a large menu and have that dynamically reduce to a thinner overlay menu on scroll. This allows the initial logo impression to remain balanced in proportion to the 'BRL-CAD' title text and overlapping with the dynamic canvas, which I think is important to retain. A minor issue on Mac platform, the menu fonts are now distinctly different (undesirably so) from the rest of the page which uses a thicker sans serif. |
I liked the idea of scroll then fix navigation menu. The de-emphasis on the menu was intended keeping in mind the fitts law, and also so that there are fewer elements demanding attention above the cover. Though the appeal is subjective, I understand the visual imbalance it's creating. Will work on creating a scroll-then-fix menu which is larger at first. Will also suggest gauravjeet to change it's vertical rhythm, he has already made font-sizes smaller in PR #13 to provide a balance. I will advise him to make them larger keeping this in mind. |
Regarding fonts, the fonts are very inconsistently defined across the CSS file. Somewhere it's And none of the fonts are actually loaded into the website. So we are on the mercy of user installing these fonts on their desktop for a consistent view. I think we should link a font like Open Sans, and keep it primary font. So the font definition everywhere would be
|
@brlcad Can you please also post a screenshot here for me to understand the font issue better, thanks! :) |
Compatibility with navigation
The new navigation as stated in issue #9 and issue #7 is not in consistency with those at http://beta.brlcad.org/wiki/Main_Page . In this pull request I have incorporated the navigation from http://ishwerdas.com/brlcad/ .
The result of merging this pull request can be seen at http://ishwerdas.com/black/