Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The new About page for the website! #36

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

The new About page for the website! #36

wants to merge 7 commits into from

Conversation

Sahil2004
Copy link

There are three images attached to the page!

All the images are free or open-sourced images.

These are the three images for the new about page. All the images are free and open-sourced. The link from where I have picked them is given in the about.html page uploaded, next to the image reference using <img> tag.
@brlcad
Copy link
Member

brlcad commented Dec 24, 2019

Sahil, this looks pretty good except that you don't link any of the existing pages to your about page. Add another commit (to this same pull request, not a new/additional one) where you link in your page on the site menu bar.

Changed and corrected the links on the page!
Updated the links for the about page!
@brlcad
Copy link
Member

brlcad commented Dec 25, 2019

It looks like you updated the link to an invalid link (about vs about.html)... Did you test your changes?

@Sahil2004
Copy link
Author

Oh, sorry! I just forgot that I had to do about.html and not merely about! I actually did it in GitHub and didn't test the changes. But I have now checked the changes and did it!

@brlcad
Copy link
Member

brlcad commented Dec 26, 2019

This looks fixed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants