Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/collection of valid mapped schemas #632

Merged
merged 12 commits into from
Sep 15, 2023

Conversation

jjjasper
Copy link
Contributor

@jjjasper jjjasper commented Sep 11, 2023

Fix regression & add tests to prevent regressions.
Fixes: #619
Also fix broken pojo field validations: #633

Copy link
Contributor

@miladbb miladbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

88.0% 88.0% Coverage
0.0% 0.0% Duplication

@jjjasper jjjasper merged commit c5cdabb into main Sep 15, 2023
3 checks passed
@jjjasper jjjasper deleted the fix/collection-of-valid-mapped-schemas branch January 2, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Validation annotations on collection items" breaks "Rewrite the validated fully qualified classname"
4 participants