Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes [ordered] comparisons in PowerShell 5.1; Fixes OpenAPI version validation check in PowerShell 5.1; Fixes for various OpenAPI issues #1358

Merged
merged 8 commits into from
Jul 20, 2024

Conversation

mdaneri
Copy link
Contributor

@mdaneri mdaneri commented Jul 11, 2024

FIxes:

[ValidateSet( 3.1 , 3.0 )] 
[decimal] 

Changed to

[ValidateSet( '3.1' , '3.0' )] 
[string]
  • AdditionalProperties now properly renders any properties assigned
  • Remove an issue with examples in New-PodeOARequestBody
  • Add Example and Examples to ConverTo-PodeOAParameter when the property Style is present
  • Block Set-PodeOARouteInfo to change the Definition Tags of a Route if already set
  • Fix the removal of the OpenAPI metadata in Remove-PodeRoute when the same route is configured to multiple endpoint

mdaneri and others added 8 commits July 11, 2024 07:43
FIxes:
- Poweshell 5.1 dislike `-is [ordered] ` has to be changed to `-is [System.Collections.Specialized.OrderedDictionary]` :(
- Some Version of PoweShell 5.1 doesn't understand  [ValidateSet( 3.1 , 3.0 )] [decimal] changed to [ValidateSet( '3.1' , '3.0' )] [string]
AdditionalProperties now properly renders any properties assigned
Remove an issue with examples in `New-PodeOARequestBody`
Add `Example` and `Examples` to `ConverTo-PodeOAParameter` when the property `Style` is present
Block `Set-PodeOARouteInfo` to change the Definition Tags of a Route if already set
Fix the romoval of the OpenAPI metadata in `Remove-PodeRoute` when the same route is configured to multiple endpoint
@Badgerati Badgerati added this to the 2.11.0 milestone Jul 20, 2024
@Badgerati Badgerati linked an issue Jul 20, 2024 that may be closed by this pull request
@Badgerati Badgerati changed the title OpenAPI fixes Fixes [ordered] comparisons in PowerShell 5.1; Fixes OpenAPI version validation check in PowerShell 5.1; Fixes for various OpenAPI issues Jul 20, 2024
@Badgerati Badgerati merged commit d8a35f1 into Badgerati:develop Jul 20, 2024
13 of 14 checks passed
@Badgerati Badgerati mentioned this pull request Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test-PodeOAVersion version value validation
2 participants