Fixes SSL timeouts when running Pode in PS7.4+ #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, to help detect SSL issues in the future
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Refactors the .NET Socket receiver and SslStream logic so that they are compliant with I/O changes made in .NET8. The changes are also recommended from .NET6 as well.
While this refactor resolves the primary "HTTPS timeout" issue when running Pode in PS7.4+, there is a more than likely chance that this change will resolve other issues as well.
Socket.ReceiveAsync, once a Socket has connected and been Accepted, Pode defaults straight to callingReadAsyncon theNetworkStream- orSslStreamfor any SSL connectionsThis change does impact HTTP, WebSockets, SMTP, and TCP endpoints.
Related Issue
Resolves #1291
Resolves #977