fix: correct wrong behavior of the key property named deprecated (bch…

…erny#626)
BatLeDev · Feb 11, 2025 · f6ed6a1 · f6ed6a1
1 parent a5834aa
commit f6ed6a1
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 0 deletions.
diff --git a/src/validator.ts b/src/validator.ts
@@ -39,6 +39,9 @@ rules.set('When minItems exists, minItems >= 0', schema => {
 
 rules.set('deprecated must be a boolean', schema => {
   const typeOfDeprecated = typeof schema.deprecated
+  if (schema.properties && 'deprecated' in schema.properties) {
+    return true
+  }
   return typeOfDeprecated === 'boolean' || typeOfDeprecated === 'undefined'
 })
 

diff --git a/test/__snapshots__/test/test.ts.md b/test/__snapshots__/test/test.ts.md
@@ -863,6 +863,7 @@ Generated by [AVA](https://avajs.dev).
        */␊
       lastName?: string;␊
       description?: string;␊
+      deprecated?: boolean;␊
     }␊
     `
 

diff --git a/test/__snapshots__/test/test.ts.snap b/test/__snapshots__/test/test.ts.snap
diff --git a/test/e2e/deprecated.ts b/test/e2e/deprecated.ts
@@ -24,6 +24,11 @@ export const input = {
     description: {
       type: 'string',
     },
+    // https://github.com/bcherny/json-schema-to-typescript/issues/626
+    deprecated: {
+      default: false,
+      type: 'boolean',
+    },
   },
   additionalProperties: false,
   required: ['firstName'],
-Original file line number
+Diff line change
@@ Expand Up / @@ -863,6 +863,7 @@ Generated by [AVA](https://avajs.dev). @@
            */␊
           lastName?: string;␊
           description?: string;␊
+          deprecated?: boolean;␊
         }␊
         `
@@ Expand Down @@