This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Edit and rotate #334
Merged
Edit and rotate #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fix selection |
PatchesMaps
commented
Sep 21, 2021
src/FeatureEditor/FeatureEditor.js
Outdated
| const geometry = editFeatures.getArray()[0].getGeometry() | ||
| const rotationDiff = val - rotation | ||
|
|
||
| this.setState({ rotation: val }, () => geometry.rotate(-rotationDiff * (Math.PI / 45), anchor)) |
There was a problem hiding this comment.
comment the weirdness
PatchesMaps
commented
Sep 21, 2021
src/Popup/Popup.js
Outdated
| map.getTargetElement() | ||
| ) | ||
| ) | ||
| ReactDOM.createPortal( |
There was a problem hiding this comment.
Revert these changes, make Feature Editor a peer of Popup, and pass the editFeature from the edit action item to the FeatureEditor through context.
PatchesMaps
commented
Oct 8, 2021
src/Map/Map.js
Outdated
| @@ -158,6 +158,7 @@ class Map extends React.Component { | |||
|
|
|||
| Map.defaultProps = { | |||
| addMapToContext: () => {}, | |||
| onEdit: () => {}, | |||
PatchesMaps
commented
Oct 8, 2021
src/Popup/Popup.js
Outdated
|
|
||
| // stop tracking movement when popup show is set to false | ||
| this.movementListener && removeMovementListener(this.movementListener) | ||
|
|
||
| this.setState({ ...this.defaultState }, () => onMapClick(this.state)) | ||
| this.setState( |
PatchesMaps
commented
Oct 8, 2021
| onClick = () => { | ||
| const { addEditFeatureToContext, feature } = this.props | ||
|
|
||
| addEditFeatureToContext(feature) |
There was a problem hiding this comment.
call callback... just in case
PatchesMaps
commented
Oct 19, 2021
| const { addEditFeatureToContext, feature, onEdit } = this.props | ||
|
|
||
| addEditFeatureToContext(feature) | ||
| onEdit() |
There was a problem hiding this comment.
pass feature through
PatchesMaps
added
ready to ship 🚀
stazrad
approved these changes
Oct 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: attach_gh_issue_here
PR Safety Checklist:
package.json&package-lock.jsonversion numbers to appropriate releasenpm run docsQuick Description of Changes (+ screenshots for ui changes):