Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

allow contextProps to be passed to <Map> #349

Merged
merged 9 commits into from
Oct 11, 2021
Merged

allow contextProps to be passed to <Map> #349

merged 9 commits into from
Oct 11, 2021

Conversation

stazrad
Copy link
Contributor

@stazrad stazrad commented Sep 21, 2021

Resolves: attach_gh_issue_here

PR Safety Checklist:

  • Added the task to the appropriate release doc under Enhancements or Bug Fixes
  • Bump package.json & package-lock.json version numbers to appropriate release
  • (optional) All external API changes have been documented
  • (optional) Build docs: npm run docs

Quick Description of Changes (+ screenshots for ui changes):

@stazrad stazrad added the ready to review 🤞 Ready and waiting on team review label Sep 21, 2021
@stazrad stazrad added documentation Improvements or additions to documentation team reviewed 👀 PR reviewed by maintainers and removed ready to review 🤞 Ready and waiting on team review labels Sep 30, 2021
@stazrad stazrad removed the documentation Improvements or additions to documentation label Oct 6, 2021
@@ -8,7 +8,7 @@ function _Map (props) {
return (
!MultiMapContext
? (
<Provider>
<Provider {...props}>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this allows contextProps to be continuously updated from consuming apps

@stazrad stazrad merged commit 44344e6 into master Oct 11, 2021
@stazrad stazrad deleted the contextProps branch October 11, 2021 18:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team reviewed 👀 PR reviewed by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants