This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Issue 365 npm audit fix #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akuma1
requested review from
chrisreams91,
DAndrews99,
drodenberg,
introvertedspud and
PatchesMaps
as code owners
stazrad
reviewed
Dec 6, 2021
| @@ -151,24 +150,24 @@ | |||
| "@babel/preset-react": "~7.7.0", | |||
| "@babel/runtime": "~7.7.2", | |||
| "@hot-loader/react-dom": "~16.13.0", | |||
| "@testing-library/dom": "~7.0.4", | |||
| "@seneca/vorpal": "^2.1.1", | |||
There was a problem hiding this comment.
why the new vorpal dep here?
There was a problem hiding this comment.
original Vorpal dependency was last published to npm 5 years back and that has many security vulnerabilities including a critical security vulnerability. This forked version of Vorpal addresses those security vulnerabilities. Our long term plan is to completely re-write our cli to use some modern cli library like @boost/cli.
stazrad
approved these changes
Dec 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #365
PR Safety Checklist:
package.json&package-lock.jsonversion numbers to appropriate releasenpm run docsQuick Description of Changes (+ screenshots for ui changes):