Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Detect CREATE TABLE statements without schema prefix #236

Conversation

spdawson
Copy link
Contributor

Description

Previously, we would only detect CREATE TABLE statements where the table name is qualified by the public. schema prefix. This prefix will not always be present, even for PostgreSQL; it will certainly not be present for MySQL.

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

Previously, we would only detect `CREATE TABLE` statements where
the table name is qualified by the `public.` schema prefix. This
prefix will not always be present, even for PostgreSQL; it will
certainly not be present for MySQL.
@swarmia
Copy link

swarmia bot commented Dec 13, 2022

1 similar comment
@swarmia
Copy link

swarmia bot commented Dec 13, 2022

@spdawson spdawson merged commit fd321c1 into main Dec 13, 2022
@spdawson spdawson deleted the AMA-3351-support-my-sql-create-table-statements-no-public-schema-prefix-on-table-name branch December 13, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants