fix: Include correct indentation in first line of policy breach context #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we would omit any and all content that precedes the match, on the first line of the match context. In particular, if the first line of a match has initial whitespace, then this would be trimmed in the output. Unfortunately, in order to reconstruct the first line fully, we must re-read it from the originating file. This is done using a line scanner, to avoid reading the entire file into memory. Nevertheless, this is sub-optimal; in the future, it may be worthwhile improving on this implementation. Also: show only a single-line code extract, when the policy dictates that parent context be omitted.
spdawson
force-pushed
the
AMA-3340-fix-indentation-of-first-line-of-code-excerpt-in-policy-report-we-are-trimming-the-indentation-of-the-first-line
branch
from
d1e4bce to
cf88322
Compare
spdawson
force-pushed
the
AMA-3340-fix-indentation-of-first-line-of-code-excerpt-in-policy-report-we-are-trimming-the-indentation-of-the-first-line
branch
from
cf88322 to
2400673
Compare
spdawson
deleted the
AMA-3340-fix-indentation-of-first-line-of-code-excerpt-in-policy-report-we-are-trimming-the-indentation-of-the-first-line
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, we would omit any and all content that precedes the match, on the first line of the match context. In particular, if the first line of a match has initial whitespace, then this would be trimmed in the output.
Unfortunately, in order to reconstruct the first line fully, we must re-read it from the originating file. This is done using a
line scanner, to avoid reading the entire file into memory. Nevertheless, this is sub-optimal; in the future, it may be worthwhile improving on this implementation.
Also: show only a single-line code extract, when the policy dictates that parent context be omitted.
Screenshots
Before
After
Checklist