Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure ids are added to detections for policy reports #241

Merged
merged 1 commit into from
Dec 13, 2022
Merged

fix: ensure ids are added to detections for policy reports #241

merged 1 commit into from
Dec 13, 2022

Conversation

didroe
Copy link
Contributor

@didroe didroe commented Dec 13, 2022

Description

Ensure that ids are added to detections when generating policy reports.

We were adding ids in some codepaths but not others (eg. YAML/JSON reports worked but not the default/text report).

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@swarmia
Copy link

swarmia bot commented Dec 13, 2022

✅  Linked to AMA-3353 · Error when processing policies with encrypted fields

@didroe didroe merged commit 63cad71 into main Dec 13, 2022
@didroe didroe deleted the AMA-3353/fix-policies-when-encrypted-fields branch December 13, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spdawson spdawson spdawson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@didroe @spdawson