Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add external service count to policies report placeholder output #259

Merged
merged 2 commits into from
Dec 15, 2022
Merged

feat: Add external service count to policies report placeholder output #259

merged 2 commits into from
Dec 15, 2022

Conversation

spdawson
Copy link
Contributor

@spdawson spdawson commented Dec 15, 2022 •
edited
Loading

Description

This uses the newly-exposed component type in the dataflow report; when the component type is "external_service", then we count the component as an external API.

Also change the previous internal service counting scheme to use the new mechanism.

Note

This also changes the titles for some list items in the output, to reduce the potential for confusion:

  • "external API(s)" -> "external service(s)"
  • "internal API(s)" -> "internal URL(s)"

Screenshots

Screenshot_2022-12-15_15-14-39

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@spdawson spdawson requested a review from elsapet December 15, 2022 13:27
@spdawson spdawson force-pushed the feat/add-external-service-count-to-policies-report-placeholder-output branch 2 times, most recently from aff7a3c to 7fdd599 Compare December 15, 2022 15:16
@spdawson spdawson changed the title feat: Add external API count to policies report placeholder output feat: Add external service count to policies report placeholder output Dec 15, 2022
@spdawson
feat: Add external API count to policies report placeholder output
3bff695 
This uses the newly-exposed component type in the dataflow report;
when the component type is `"external_service"`, then we count
the component as an external API.

Also change the previous internal service counting scheme to use
the new mechanism.
@spdawson spdawson force-pushed the feat/add-external-service-count-to-policies-report-placeholder-output branch from 7fdd599 to 3bff695 Compare December 15, 2022 15:31
@gotbadger gotbadger merged commit 9895d53 into main Dec 15, 2022
@gotbadger gotbadger deleted the feat/add-external-service-count-to-policies-report-placeholder-output branch December 15, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elsapet elsapet elsapet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spdawson @elsapet @gotbadger