Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix bad flag examples #263

Merged
merged 2 commits into from
Dec 15, 2022
Merged

fix: fix bad flag examples #263

merged 2 commits into from
Dec 15, 2022

Conversation

elsapet
Copy link
Contributor

@elsapet elsapet commented Dec 15, 2022

Description

Fixing some outdated flag docs - we were giving default values in the description that weren't ideal
Also fixed bad example for internal domain (invalid regex)

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@elsapet elsapet requested a review from markmichon December 15, 2022 15:22
spdawson
spdawson approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@spdawson spdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@cfabianski cfabianski merged commit e047f56 into main Dec 15, 2022
@cfabianski cfabianski deleted the fix/fix-bad-example branch December 15, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmichon markmichon markmichon approved these changes

@spdawson spdawson spdawson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elsapet @spdawson @markmichon @cfabianski