Adjust source files to be compatible with changes I made to the Math module #1438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…module The Chapel team is in the process of splitting the Math standard library into a portion that continues to be included by default and one that will require a `use` or `import` statement going forward. To maintain compatibility with both the previous releases and main/the upcoming release, update these files to no longer use explicit naming to access the symbols in that module (since the ones that are being included by default are no longer in the module named "Math" but are instead in a new module named "AutoMath" that won't exist for previous releases) ---- Signed-off-by: Lydia Duncan <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
That test was complaining it could not find AryUtil, because the 1.27 pre-release has changed our handling of `public use` to no longer bring in the name of the module in addition to the symbols it contains, unless an `as` clause is used. Add an `as` clause so that the name is now brought in again. I believe this was missed due to not running testing locally. ---- Signed-off-by: Lydia Duncan <[email protected]>
|
@mhmerrill or @reuster986 - would one of you be able to review this PR? |
mhmerrill
requested review from
stress-tess,
reuster986,
mhmerrill and
Ethan-DeBandi99
stress-tess
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Chapel team is in the process of splitting the Math standard library into a
portion that continues to be included by default and one that will require a
useorimportstatement going forward. To maintain compatibility with boththe previous releases and main/the upcoming release, update these files to no
longer use explicit naming to access the symbols in that module (since the ones
that are being included by default are no longer in the module named "Math" but
are instead in a new module named "AutoMath" that won't exist for previous
releases)
While here, I also updated test/TestBase.chpl to fix the issue test/UnitTestSort.chpl
was encountering with latest Chapel main. That test was complaining it could not
find AryUtil, because the 1.27 pre-release has changed our handling of
public useto no longer bring in the name of the module in addition to the symbols it contains,
unless an
asclause is used. Add anasclause so that the name is nowbrought in again. (see chapel-lang/chapel#19306 (comment)
for how the scoping rules are expected to change in the upcoming 1.27 release)