Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: mark class as deprecated before next major version #85

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

shavounet
Copy link
Contributor

@shavounet shavounet commented Oct 12, 2023

Why?

The curlInfo dynamic property is deprecated in PHP8.2 and will be removed in favor of the native on_stat option

How?

@deprecated should trigger warnings in CI to notice people about this change

Copy link
Member

@Oliboy50 Oliboy50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷

@shavounet shavounet force-pushed the feat/mark-deprecations-v5 branch from 0e1d89a to 49a3e11 Compare October 13, 2023 08:06
@shavounet shavounet changed the base branch from master to fix/ci October 13, 2023 08:07
@shavounet shavounet marked this pull request as ready for review October 13, 2023 08:40
@shavounet shavounet requested a review from a team as a code owner October 13, 2023 08:40
Base automatically changed from fix/ci to master October 26, 2023 09:09
@shavounet shavounet force-pushed the feat/mark-deprecations-v5 branch from 49a3e11 to ac9c6dd Compare October 26, 2023 09:11
@shavounet shavounet merged commit 768b094 into master Oct 26, 2023
14 checks passed
@shavounet shavounet deleted the feat/mark-deprecations-v5 branch October 26, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants