Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify or downgrade id function #7

Open
meowsbits opened this issue Mar 4, 2019 · 0 comments
Open

Simplify or downgrade id function #7

meowsbits opened this issue Mar 4, 2019 · 0 comments

Comments

@meowsbits
Copy link

meowsbits commented Mar 4, 2019

Is your feature request related to a problem? Please describe.

re: name -> hash as an identifier scheme. OpenSSL only began support for SHA3 in 2018-09. There are no security reasons for the hashing pattern, we just need unique IDs. Also SHA3-512 is kind of slow.

I think we should try to make the process of getting an id and the id itself as simple as possible.

Note also that since we'd be using a tiny substring of the hash, there's really no point in the extra bits (512 is overkill).

Describe the solution you'd like

  • Use MD5. It gives a very reasonable enough chance of non-collisions. SHA1 would work fine too.

Describe alternatives you've considered

  • id = "Just pick any noun that isn't taken or make up a word".

  • screenshot_20190304_081420

Additional context

Rel #5

$ openssl version
OpenSSL 1.1.0g  2 Nov 2017

⚠️ https://github.com/BelfordZ/starIPs/blame/master/README.md#L17 != Resulting \*IP Name: ECIP-cebf0a05``

screenshot_20190304_075643

https://duckduckgo.com/?q=sha512+Byzantium+Upgrades+on+block+123123&t=canonical&ia=answer

$ echo -n "Byzantium Upgrades on block 123123" | openssl sha512 | tr -d '\n' | tail -c8
a3b1f29c

screenshot_20190304_074934

https://duckduckgo.com/?q=md5+Byzantium+Upgrades+on+block+123123&t=canonical&ia=answer

$ echo -n "Byzantium Upgrades on block 123123" | openssl md5 | tr -d '\n' | tail -c8
8300750f
@meowsbits meowsbits changed the title Simplify or downgrade hash -> id function Simplify or downgrade id function Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant