Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hash the preamble #10

Merged
merged 8 commits into from
Mar 18, 2019
Merged

fix: hash the preamble #10

merged 8 commits into from
Mar 18, 2019

Conversation

BelfordZ
Copy link
Owner

@BelfordZ BelfordZ commented Mar 12, 2019 •
edited
Loading

fixes #9 #11

@BelfordZ BelfordZ mentioned this pull request Mar 12, 2019
Open
@BelfordZ BelfordZ requested a review from phyro March 12, 2019 19:55
@BelfordZ BelfordZ self-assigned this Mar 12, 2019
@phyro
Copy link
Collaborator

phyro commented Mar 12, 2019

fixed the conflict due to the contributors being merged, not merging because of BASE58 suggestion from pyskell here #11

whilei
whilei reviewed Mar 12, 2019
View reviewed changes
whilei
whilei reviewed Mar 12, 2019
View reviewed changes
whilei
whilei reviewed Mar 12, 2019
View reviewed changes
whilei
whilei reviewed Mar 12, 2019
View reviewed changes
whilei
whilei reviewed Mar 12, 2019
View reviewed changes
whilei
whilei reviewed Mar 12, 2019
View reviewed changes
@ghost ghost changed the title fix: hash the preable fix: hash the premable Mar 12, 2019
@ghost ghost changed the title fix: hash the premable fix: hash the preamble Mar 12, 2019
@ghost ghost mentioned this pull request Mar 13, 2019
Closed
@whilei @BelfordZ
fix: typo
2d326c7 
Co-Authored-By: BelfordZ <[email protected]>
pyskell
pyskell reviewed Mar 13, 2019
View reviewed changes
@pyskell
feat: BASE58 + minor changes
2c60d5e 
Changed:
- SHA-3 512 -> BASE58(SHA-3 512)
- Suggesting 8 characters for the version hash. In actuality 11 characters would be equivalent to 16 of a sha3 hash.
- Suggesting 4 characters for the proposal number. In actuality 3.43 characters would be equivalent to 5 of a sha3 hash. Rounded up. 4 is also a nice and common scheme.
- Typo on the word acronym
pyskell
pyskell reviewed Mar 13, 2019
View reviewed changes
@YazzyYaz
Merge pull request #13 from BelfordZ/base58
b6ae2d3 
feat: BASE58 + minor changes
@BelfordZ
Copy link
Owner Author

@phyro @pyskell @YazzyYaz @whilei needs a review plz

YazzyYaz
YazzyYaz reviewed Mar 18, 2019
View reviewed changes
@BelfordZ BelfordZ requested review from YazzyYaz, a user and pyskell and removed request for a user March 18, 2019 16:30
@YazzyYaz YazzyYaz merged commit 1b5f07b into master Mar 18, 2019
@BelfordZ BelfordZ deleted the fix/preable-hash branch March 18, 2019 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whilei whilei whilei left review comments

@YazzyYaz YazzyYaz YazzyYaz approved these changes

@phyro phyro Awaiting requested review from phyro

@pyskell pyskell Awaiting requested review from pyskell

Assignees

@BelfordZ BelfordZ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hash should be the *ip preamble
5 participants
@BelfordZ @phyro @YazzyYaz @pyskell @whilei