Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an NPM Package for Typescript types and interfaces #1063

Closed
migbash opened this issue Feb 20, 2023 · 3 comments · Fixed by #1107
Closed

Create an NPM Package for Typescript types and interfaces #1063

migbash opened this issue Feb 20, 2023 · 3 comments · Fixed by #1107
Assignees
Labels
documentation Improvements or additions to documentation 🔄 [ST] background Happening in the background and active. Out of direct control. ⏳ [ST] validating In a passive-active state. Being inspected and checked. ℹ️ [T] optimization Improvement |:| Optimazation of (1) throttle, (2) speed related issues.

Comments

@migbash
Copy link
Collaborator

migbash commented Feb 20, 2023

NOTES

The project has grown quite large very quickly. And to keep up with the development speed, with the cache and frontend sharing exactly the same types and interfaces - with being dependent on one another. Copying over constantly the updated interfaces and types slows development and is not ideal.

SOLUTION: create an NPM Package with all the types and interfaces used by both cache and scores-platform for better management. As we have hundreds of different types.


@jonsnowpt https://docs.npmjs.com/creating-an-organization

@migbash migbash converted this from a draft issue Feb 20, 2023
@migbash migbash added documentation Improvements or additions to documentation ℹ️ [T] optimization Improvement |:| Optimazation of (1) throttle, (2) speed related issues. labels Feb 20, 2023
@migbash migbash moved this from Backlog to Todo in Betarena Scores Feb 20, 2023
@migbash migbash moved this from Todo to Backlog in Betarena Scores Feb 20, 2023
@jonsnowpt jonsnowpt moved this from Backlog to Icebox in Betarena Scores Feb 21, 2023
@jonsnowpt jonsnowpt moved this from Icebox to Todo in Betarena Scores Feb 21, 2023
@jonsnowpt
Copy link
Contributor

@migbash

Can it be public packages?

@migbash
Copy link
Collaborator Author

migbash commented Mar 2, 2023

NOTES

🟢 Live on https://www.npmjs.com/package/@betarena/scores-lib, with it's repo on https://github.com/Betarena/scores-lib

Utilized by the scores (frontend) and cache - sharing identifcal declarations and methods - easing up development.

Only utilized by Livescores-V2 for now.


Main | Layout

  • navbar
  • footer
  • sportbook
  • pages-and-seo
  • auth
  • profile

Home | Page

  • livescores-v2
  • featured-match
  • featured-betsite
  • league-list
  • league-table
  • seo-block
  • best-goalscorers

Fixture | Page

  • standings
  • top-players
  • league-info
  • fixture-odds

Fixture | Page

  • scoreboard
  • content
  • lineups
  • about
  • head-2-head
  • votes
  • probabilities
  • incidents
  • statistics

Upon completion of the above, the scores (frontend) needs to be updated to use the correct types and declarations from the @betarena/scores-lib


UPDATE - 09/03/23

Proceeding onto testing and final integration checks;


UPDATE - 12/03/2023

All data generated in the cache using the bull-workers is correctly updated (local), using the scores-lib (local) env. Direct email alerts has been configured for the ultimate alert system for any errors of on("failed") bull job execution, so deployment to production is safeguarded if anything goes wrong. This completes the migration of the cache and frontend to the @betarena/scores-lib NPM package - with shared code blocks and types and GraphQL. This aims to reduce development time, increase code reliability of methods and data generation for cache/hasura FETCH's and ensure correct logic across both applications.

@migbash migbash moved this from Todo to In Progress in Betarena Scores Mar 2, 2023
migbash added a commit that referenced this issue Mar 6, 2023
migbash added a commit that referenced this issue Mar 6, 2023
migbash added a commit that referenced this issue Mar 6, 2023
migbash added a commit that referenced this issue Mar 6, 2023
migbash added a commit that referenced this issue Mar 6, 2023
migbash added a commit that referenced this issue Mar 6, 2023
migbash added a commit that referenced this issue Mar 6, 2023
migbash added a commit that referenced this issue Mar 6, 2023
migbash added a commit that referenced this issue Mar 6, 2023
migbash added a commit that referenced this issue Mar 6, 2023
migbash added a commit that referenced this issue Mar 6, 2023
migbash added a commit that referenced this issue Mar 6, 2023
migbash added a commit that referenced this issue Mar 7, 2023
@migbash migbash mentioned this issue Mar 7, 2023
14 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in Betarena Scores Mar 7, 2023
@migbash migbash reopened this Mar 8, 2023
@migbash migbash moved this from Done to In Progress in Betarena Scores Mar 8, 2023
migbash added a commit that referenced this issue Mar 12, 2023
@migbash migbash added ⏳ [ST] validating In a passive-active state. Being inspected and checked. 🔄 [ST] background Happening in the background and active. Out of direct control. labels Mar 12, 2023
@migbash migbash moved this from In Progress to Testing in Betarena Scores Mar 12, 2023
@migbash
Copy link
Collaborator Author

migbash commented Mar 14, 2023

NOTES

Version labelled as major => 0.7.0 is release and is being tested - with bugs and fixes being made to bring it correctly, but issue can be closed as completed as groundwork is laid and no further tectonic shifts in the code structure/implementation have to be made, only corrections and add further documentation.

@migbash migbash closed this as completed Mar 14, 2023
@github-project-automation github-project-automation bot moved this from Testing to Done in Betarena Scores Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation 🔄 [ST] background Happening in the background and active. Out of direct control. ⏳ [ST] validating In a passive-active state. Being inspected and checked. ℹ️ [T] optimization Improvement |:| Optimazation of (1) throttle, (2) speed related issues.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants