Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lang selection behavior change #1089

Closed
jonsnowpt opened this issue Mar 1, 2023 · 5 comments
Closed

Lang selection behavior change #1089

jonsnowpt opened this issue Mar 1, 2023 · 5 comments
Assignees
@migbash
Labels
🐞 [A] bug Something isn't working. Needs to be looked at. 📣 [A] high priority Something that needs attention and accelerated resolving

Comments

@jonsnowpt
Copy link
Contributor

jonsnowpt commented Mar 1, 2023 •
edited
Loading

🐛 Introduction:

At this time, the lang change on the front of the platform is not affecting the Firestore language, creating issues when changing the language and browsing the platform.

📝 Details:

If the FR language is selected in the profile section and we change it on the platform home page and access a fixture it will redirect the fixture incorrectly.

🔍 Steps to Reproduce:

  • Define a language in the profile section;
  • Change it on the Homepage;
  • Visit a fixture;

🤔 Expected Behavior:

Change the language in any section, get the same behavior, and correct link redirection.

💥 Actual Behavior:

Incorrect link redirect when browsing the fixtures in the platform.

💡 Additional Information:

Also, when a user visits the platform it should be redirected to his defined language (Firestore) and not be kept in the new language.
@jonsnowpt jonsnowpt self-assigned this Mar 1, 2023
@jonsnowpt jonsnowpt converted this from a draft issue Mar 1, 2023
@jonsnowpt jonsnowpt added the 🐞 [A] bug Something isn't working. Needs to be looked at. label Mar 1, 2023
@jonsnowpt jonsnowpt changed the title Lang selection behaviour change Lang selection behavior change Mar 1, 2023
@jonsnowpt jonsnowpt added the 📣 [A] high priority Something that needs attention and accelerated resolving label Mar 1, 2023
@jonsnowpt jonsnowpt moved this to Backlog in Betarena Scores Mar 1, 2023
@jonsnowpt jonsnowpt moved this from Backlog to Icebox in Betarena Scores Mar 6, 2023
@jonsnowpt jonsnowpt moved this from Icebox to Todo in Betarena Scores Mar 8, 2023
@jonsnowpt jonsnowpt assigned migbash and unassigned jonsnowpt Mar 8, 2023
@migbash migbash moved this from Todo to In Progress in Betarena Scores Mar 13, 2023
@migbash
Copy link
Collaborator

migbash commented Mar 14, 2023 •
edited
Loading

NOTES

updated

@jonsnowpt deployed to 🚀 DEV

migbash added a commit that referenced this issue Mar 14, 2023
@migbash
issue: #1089; add debug improve redirect;
8e666c5
@migbash migbash moved this from In Progress to Staging in Betarena Scores Mar 14, 2023
@migbash migbash moved this from Staging to Testing in Betarena Scores Mar 14, 2023
@jonsnowpt
Copy link
Contributor Author

@migbash

Not working correctly.

The Live-Score is not changing the fixtures links accordingly.

@jonsnowpt jonsnowpt moved this from Testing to Todo in Betarena Scores Mar 14, 2023
migbash added a commit that referenced this issue Mar 14, 2023
@migbash
fix: #1089; test: fix server-lang ripple;
40c39f6
@migbash migbash moved this from Todo to Staging in Betarena Scores Mar 14, 2023
@migbash
Copy link
Collaborator

migbash commented Mar 14, 2023 •
edited
Loading

NOTES

updated

@jonsnowpt deployed to 🚀 DEV

@jonsnowpt
Copy link
Contributor Author

@migbash

Still need adjustments.

@jonsnowpt jonsnowpt moved this from Staging to Todo in Betarena Scores Mar 14, 2023
migbash added a commit that referenced this issue Mar 14, 2023
@migbash
fix: #1089; test: fix server-lang ripple;
5c5f39b
@migbash migbash moved this from Todo to Staging in Betarena Scores Mar 14, 2023
@migbash
Copy link
Collaborator

migbash commented Mar 14, 2023

NOTES

updated

@jonsnowpt deployed to 🚀 DEV

@migbash migbash moved this from Staging to Testing in Betarena Scores Mar 14, 2023
@github-project-automation github-project-automation bot moved this from Testing to Done in Betarena Scores Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@migbash migbash

Labels
🐞 [A] bug Something isn't working. Needs to be looked at. 📣 [A] high priority Something that needs attention and accelerated resolving
Projects
Betarena Scores
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@migbash @jonsnowpt