Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Fixture competition widget corrections #1765

Closed
9 of 17 tasks
jonsnowpt opened this issue Oct 17, 2023 · 7 comments
Closed
9 of 17 tasks

[Bug]: Fixture competition widget corrections #1765

jonsnowpt opened this issue Oct 17, 2023 · 7 comments
Assignees
@jonsnowpt
Labels
🐞 [A] bug Something isn't working. Needs to be looked at. 🎨 Frontend
Milestone
[FEATURE]: Compet...

Comments

@jonsnowpt
Copy link
Contributor

jonsnowpt commented Oct 17, 2023 •
edited by migbash
Loading

Is there an existing issue for this?

  • I have searched the existing issues

🐞 Describe the bug

  • Title alignment
  • Space for the probability, entry fee and Total prize;
  • Join No Dark wrong color
  • Participants avatar without the circle;
  • White version colors are wrong and the boxes do not have shadows;

Screenshot 2023-10-17 at 16 06 22

Screenshot 2023-10-17 at 16 09 29

Screenshot 2023-10-17 at 16 11 48

🤔 Expected Behavior

Follow the Figma instructions.

What environment is the bug/issue detected in.

  • Production (scores.betarena.com)
  • Development

What browsers are you seeing the problem on?

  • Firefox
  • Chrome
  • Safari
  • Microsoft Edge
  • Brave
  • Opera

What device/platform can the problem be seen?

  • 📱 Mobile
  • 💻 Tablet
  • 🖥️ Laptop/Desktop

Steps To Reproduce

https://betarena-scores-platform.herokuapp.com/football/amrica-mineiro-botafogo-18791308

Console Logs (if any)

No response

Anything else?

No response
@jonsnowpt jonsnowpt added 🐞 [A] bug Something isn't working. Needs to be looked at. 🎨 Frontend labels Oct 17, 2023
@jonsnowpt jonsnowpt moved this to Todo in Betarena Scores Oct 17, 2023
@migbash migbash added this to the [FEATURE]: Competitions milestone Oct 19, 2023
@migbash migbash moved this from Todo to In Progress in Betarena Scores Oct 19, 2023
@migbash
Copy link
Collaborator

migbash commented Oct 19, 2023 •
edited
Loading

Note
Corrected, awaiting 🚀 deployment.

@migbash migbash moved this from In Progress to Staging in Betarena Scores Oct 19, 2023
@migbash migbash mentioned this issue Oct 19, 2023
Closed
12 tasks
@migbash
Copy link
Collaborator

migbash commented Oct 19, 2023

Note
Live on dev from v880.

@migbash migbash moved this from Staging to Testing in Betarena Scores Oct 19, 2023
@migbash migbash assigned jonsnowpt and unassigned migbash Oct 19, 2023
@jonsnowpt
Copy link
Contributor Author

@migbash

The Join Yes and No disabled CSS is still incorrect on the dark theme:

Image

Should be like this:

Image

@jonsnowpt jonsnowpt moved this from Testing to Todo in Betarena Scores Oct 19, 2023
@jonsnowpt jonsnowpt assigned migbash and unassigned jonsnowpt Oct 19, 2023
@migbash
Copy link
Collaborator

migbash commented Oct 19, 2023

Note
Corrected addressed as part of issue ➤ #1785 .
Awaiting 🚀 deployment.

@migbash migbash moved this from Todo to Staging in Betarena Scores Oct 19, 2023
@migbash
Copy link
Collaborator

migbash commented Oct 19, 2023

Note
Live on dev from v883.

@migbash migbash moved this from Staging to Testing in Betarena Scores Oct 19, 2023
@migbash migbash assigned jonsnowpt and unassigned migbash Oct 19, 2023
@jonsnowpt
Copy link
Contributor Author

@migbash

Missing the 50% passthrough that is present on Figma.

@jonsnowpt jonsnowpt moved this from Testing to Todo in Betarena Scores Oct 19, 2023
@migbash migbash moved this from Todo to Staging in Betarena Scores Oct 19, 2023
@migbash
Copy link
Collaborator

migbash commented Oct 19, 2023

Note
Corrected, awaiting 🚀 deployment.
Live on dev from v884.

@migbash migbash moved this from Staging to Testing in Betarena Scores Oct 19, 2023
@github-project-automation github-project-automation bot moved this from Testing to Done in Betarena Scores Oct 20, 2023
migbash added a commit that referenced this issue Oct 21, 2023
@migbash
#1765 :: fix 5/5 :: comment updates; app.css update;
0f0a02f
migbash added a commit that referenced this issue Oct 21, 2023
@migbash
fix :: #1765,#1785,#1767;
25fdf5a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonsnowpt jonsnowpt

Labels
🐞 [A] bug Something isn't working. Needs to be looked at. 🎨 Frontend
Projects
Betarena Scores
Archived in project
Milestone
[FEATURE]: Competitions
Development

No branches or pull requests
2 participants
@migbash @jonsnowpt