Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: All competitions are listened for live data from Hasura #1799

Closed
6 of 12 tasks
migbash opened this issue Oct 23, 2023 · 1 comment
Closed
6 of 12 tasks

[Bug]: All competitions are listened for live data from Hasura #1799

migbash opened this issue Oct 23, 2023 · 1 comment
Assignees
@jonsnowpt
Labels
🐞 [A] bug Something isn't working. Needs to be looked at. 🎨 Frontend
Milestone
[FEATURE]: Compet...

Comments

@migbash
Copy link
Collaborator

migbash commented Oct 23, 2023

Is there an existing issue for this?

  • I have searched the existing issues

🐞 Describe the bug

It appears that the current implementation of the competitions live data listener is using that of the competitions-lobby page, meaning all competitions changes of type: published are registered and sent to the frontend. This consumes unnecessary resources and bandwidth.

🤔 Expected Behavior

Limit to one single competition-id listen for live data from Hasura, to improve performance and/or data resource.

What environment is the bug/issue detected in.

  • Production (scores.betarena.com)
  • Development

What browsers are you seeing the problem on?

  • Firefox
  • Chrome
  • Safari
  • Microsoft Edge
  • Brave
  • Opera

What device/platform can the problem be seen?

  • 📱 Mobile
  • 💻 Tablet
  • 🖥️ Laptop/Desktop

Steps To Reproduce

Simply navigate to any fixture with a competition and inspect with DevTools in < v890. You'll see data for all competitions being registered.

Console Logs (if any)

No response

Anything else?

  • First detected on: on routine testing of the dev.
@migbash migbash added 🎨 Frontend 🐞 [A] bug Something isn't working. Needs to be looked at. labels Oct 23, 2023
@migbash migbash added this to the [FEATURE]: Competitions milestone Oct 23, 2023
@migbash migbash self-assigned this Oct 23, 2023
@migbash migbash moved this to Todo in Betarena Scores Oct 23, 2023
@migbash migbash moved this from Todo to In Progress in Betarena Scores Oct 23, 2023
@migbash
Copy link
Collaborator Author

migbash commented Oct 23, 2023 •
edited
Loading

Note
Created offspring task ➤ #275.

Note
Implemented, awaiting 🚀 deployment.

Note
Live on dev from v891.

@migbash migbash moved this from In Progress to Staging in Betarena Scores Oct 24, 2023
@migbash migbash moved this from Staging to Testing in Betarena Scores Oct 24, 2023
migbash added a commit that referenced this issue Oct 24, 2023
@migbash
#1799 :: fix;
fa8e5a6
@migbash migbash assigned jonsnowpt and unassigned migbash Oct 24, 2023
@github-project-automation github-project-automation bot moved this from Testing to Done in Betarena Scores Oct 24, 2023
jonsnowpt pushed a commit that referenced this issue Oct 25, 2023
@migbash
minor (#1805)
eeb5b8f 
* core :: Makefile update;

* debug :: Sentry disable on local env; add logs;

* debug :: enhance color-coding;

* core :: Makefile update;

* Migbash/issue-1719 | fixture/competitions (#1795)

* Migbash/issue-1784 | Sentry Errors (#1796)

* fs :: move app.d.ts to types/*

* #1776 :: fix - probability widget;

* #1776 :: fix - scoreboard widget;

* #1791 :: fix - probability widget odds;

* fix :: +layout.svelte invalid route.id check;

* fix :: Header-Nav-Btn.svelte invalid route.id check;

* fix :: Header.svelte invalid route.id check;

* core :: platform-functions.ts 'dev' ignore redirect;

* fix :: patform-functions.ts invalid route.id check;

* feat :: improved error message of invalid url routes

* feat :: improved error message of invalid url routes (client)

* types :: add app.d.ts for Error (global);

* fix :: hooks.server.ts default error code + msg;

* fix :: fixture +page.ts update error handle;

* pkg :: scores-lib 1.8.2;

* Migbash/issue-1752 | competition lobby/highlights; (#1797)

* feat :: lobby/highlights data endpoint upgrade;

* doc :: OpenAPI update;

* feat :: Highlights-Grid-Row upgrade;

* feat :: Highlights-Grid upgrade;

* feat :: Highlights-Widget upgrade;

* core :: utils.ts update for 'white-space' removal of endpoints;

* pkg :: scores-lib 1.9.0;

* debug :: remove redundant console.log(..);

* #1798 :: fix;

* #1799 :: fix;

* #1776 :: fix;

* #1776 :: fix;

* test :: +page.server.ts;

* #1800 :: feat :: stable endpoint update limit;

* #1800 :: doc :: OpenApi update;

* pkg :: scores/lib 1.9.2

* Migbash/1801-FEATURE-Competitions-Cache (#1804)

* 🧪 :: test | debug :: performance improvements (2);

* #1801 :: feat :: extra corrections (cont);

* #1801 :: feat :: extra corrections (cont);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonsnowpt jonsnowpt

Labels
🐞 [A] bug Something isn't working. Needs to be looked at. 🎨 Frontend
Projects
Betarena Scores
Archived in project
Milestone
[FEATURE]: Competitions
Development

No branches or pull requests
2 participants
@migbash @jonsnowpt