Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tournaments standings missing color information #979

Closed
jonsnowpt opened this issue Jan 12, 2023 · 9 comments · Fixed by #1107
Closed

Tournaments standings missing color information #979

jonsnowpt opened this issue Jan 12, 2023 · 9 comments · Fixed by #1107
Assignees
Labels
🐞 [A] bug Something isn't working. Needs to be looked at. 📣 [A] high priority Something that needs attention and accelerated resolving

Comments

@jonsnowpt jonsnowpt converted this from a draft issue Jan 12, 2023
@jonsnowpt jonsnowpt self-assigned this Jan 12, 2023
@jonsnowpt jonsnowpt added 🐞 [A] bug Something isn't working. Needs to be looked at. 📣 [A] high priority Something that needs attention and accelerated resolving labels Jan 12, 2023
@jonsnowpt jonsnowpt moved this from Backlog to Icebox in Betarena Scores Feb 21, 2023
@jonsnowpt jonsnowpt moved this from Icebox to Todo in Betarena Scores Feb 21, 2023
@jonsnowpt jonsnowpt assigned migbash and unassigned jonsnowpt Feb 21, 2023
@migbash
Copy link
Collaborator

migbash commented Mar 2, 2023

NOTES

league_id: 1019 | season_id: 19996 (latest) | https://scores.betarena.com/football/indonesia/liga-1
Missing for:

  • pos (1): "result": "AFC Cup"

league_id: 1356 | season_id: 20243 (latest) | https://scores.betarena.com/football/australia/a-league
Missing for:

  • pos (3,4,5,6): "result": "Final Series Play-offs"

league_id: 815 | season_id: 20555 (latest) | https://scores.betarena.com/football/angola/girabola
Missing for:

  • pos (1): "result": "CAF Champions League"

league_id: 830 | season_id: 20827 (latest) | https://scores.betarena.com/football/egypt/premier-league
Missing for:

  • pos (1,2): "result": "CAF Champions League"
  • pos (3): "result": "CAF Confederation Cup"

league_id: 824 | season_id: 20813 (latest) | https://scores.betarena.com/football/congo-dr/super-ligue
Missing for:

  • pos (1,2): "result": "CAF Champions League"
  • pos (3): "result": "CAF Confederation Cup"

league_id: 208 | season_id: 19785 (latest) | https://scores.betarena.com/football/belgium/pro-league
Missing for:

  • pos (5,6,7,8): "result": "UEFA Europa League Play-off"

ADDITIONAL FROM #923

league_id: 32 | season_id: 19785 (latest) | https://scores.betarena.com/br/futebol/inglaterra/premier-league-cup
Missing for:

  • pos (1,2): "result": "8th Finals"

ADDITIONAL FROM #923

league_id: 471 | season_id: 20728 (latest) | https://scores.betarena.com/br/futebol/portugal/league-cup
Missing for:

  • pos (1): "result": "Quarter-finals"

ADDITIONAL FROM #923

league_id: 39 | season_id: 19892 (latest) | https://scores.betarena.com/br/futebol/inglaterra/efl-trophy
Missing for:

  • pos (1,2): "result": "16th Finals"

@jonsnowpt the above mentioned results: color codes are missing from the color_codes_league_standings_positions (db) and should be added as written above in the result: provided.

@migbash migbash moved this from Todo to Testing in Betarena Scores Mar 2, 2023
@jonsnowpt
Copy link
Contributor Author

@migbash

Requested, get back to you when done!

@jonsnowpt
Copy link
Contributor Author

@migbash

All colors added on Figma.

@jonsnowpt jonsnowpt moved this from Testing to Todo in Betarena Scores Mar 3, 2023
@migbash
Copy link
Collaborator

migbash commented Mar 6, 2023

NOTE

Updated on DB

@migbash migbash moved this from Todo to Testing in Betarena Scores Mar 6, 2023
@jonsnowpt
Copy link
Contributor Author

@jonsnowpt jonsnowpt moved this from Testing to Todo in Betarena Scores Mar 7, 2023
@migbash
Copy link
Collaborator

migbash commented Mar 7, 2023

@jonsnowpt Those are different links to those identified, need to check and report back. But looks like yes - more color variations are needed.

Those from this issue and #923 have been dealt with and are visible.

@jonsnowpt
Copy link
Contributor Author

@migbash

Yes, that was the reason for the two opened issues; they had different links. Please advise on the colors needed.

@migbash
Copy link
Collaborator

migbash commented Mar 7, 2023

@jonsnowpt both of those links (previous message) has the correct color-codes that we already have added - I was just missing an update, as I updated surgically (manual). I have triggered an all cache standings update. Will update when done so you can check for other missing color-codes.

@migbash migbash moved this from Todo to In Progress in Betarena Scores Mar 7, 2023
@jonsnowpt
Copy link
Contributor Author

All working.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Betarena Scores Mar 7, 2023
@migbash migbash mentioned this issue Mar 7, 2023
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 [A] bug Something isn't working. Needs to be looked at. 📣 [A] high priority Something that needs attention and accelerated resolving
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants