Feature.Tags Section/draft/0 #2088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[1] ----- Remove logic for persisting to 'debug.log' for easier debugging, only temporarily. [2] ----- Disable 'dev branch reset' workflow, as it interferes with development workflow. Will be updated to reset a 'release' branch instead. [3] ----- Update '.gitignore' to remove 'debug.log' file from GIT and ran a 'git rm --cached' on it to remove it.
|
At this stage:
Needs improvement:
Not implemented:
|
[1] ----- Displace debug logs instance declaration to 'constants/instance.ts'. This is done the same for 'cache' and 'scores-lib' project. [2] ----- Clean commenting and formatting.
…arena/scores into feature/tags-section/draft/0
…arena/scores into feature/tags-section/draft/0
…arena/scores into feature/tags-section/draft/0
[1] ----- Correct issue regadring target article page loading issue. Related to the change made of the endpoint new re-structure.
[1] ----- In light of the recent 'scores-lib version, 'debug/**' filder with files will be generated, hence, these should be always omitted from 'commits'.
jonsnowpt
pushed a commit
that referenced
this pull request
May 1, 2024
* Refactor/redis graphql restructure/draft/0 (#2084) * Chore/restructure/draft/0 (#2073) * chore: update makefile [1] Simplify make target for 'dev' setup and correct npm script target update. Includes comments clean up. * chore: update vite.config.ts (+misc) [1] Apply use of direct pacakge.json parsing and 'define' global variables respectively via vite-js. [2] Clean up console logs, comments and JsDoc. [3] Update d.ts for envrionment variables. [4] Update hooks.client.ts for latest logs and vite 'define' variables. * chore: update .eslintrc.yaml [1] Add 'no-var' and 'require-jsdoc' rules. [2] Clean up comments and JsDoc. * chore: update vscode settings [1] Update settings.json for VsCode instance with (1) cleaner comments and (2) file/directory tree-view exclusion. [2] Update debug vscode 'snippets'. [3] Add vscode extension config for 'terminals' auto-start, along with a complete config example. * chore: update .gitignore [1] Clean up comments and JsDoc. [2] Update for 'debug.log' exclusion. * chore: update codespace setup [1] Removing use of NVM due to some setup issues with Codespace. [2] Updating 'dev' script for 'scores-lib' loading over 'npm link' only. Caused errors due to absesnce of 'ad-widget'. * fix: vite hot-reload blockage [1] Update layout.svelte + package.json to remove recently pushed ad-engine widget. * refactor(connection): migrate redis + graphql logic to scores-lib (+misc) [1] ----- Update all logic to remove use of 'GraphQL' instance argument passed along to 'scores-lib' logic for entry methods. Scores-Lib will house the logic for 'GraphQL' connection instance creation. [2] ----- Update all logic to remove main use of 'Redis' client methods, such as: 'HMSET', 'SADD', etc. This logic has now been off-loaded to 'scores-lib'. * refactor(import): update module import path [1] ----- Update import paths for modules from 'scores-lib' to the correct ones. * feat(article): update author-article endpoint [1] ----- New example structure for the 'author.article.ts' data endpoint as part of the 'V8' standard. Includes 'scores-lib' import update. * chore(eslint): update ignore paths [1] ----- Update to ignore 'api/**' routes from 'EsLint'. * chore(debug): remove debug.log [1] ----- Update removal of 'debug.log' file. * refactor(misc): update key import (+misc) [1] ----- Update missing import value for one of the 'RedisKeys'. [2] ----- Code clean, commenting and format. * chore(makefile): update makefile target to use dotenv_vault secrets [1] ----- Update Makefile with the key secrets injection step. * build(scores-lib): bump to 3.0.0 * chore(graphql): update missing variable [1] ----- Update instance of target 'GraphQL' instance declaration. * Feature.Tags Section/draft/0 (#2088) * fix script error when filter returns empty mapTags (#2092) Co-authored-by: Ivan Izobov <[email protected]> --------- Co-authored-by: Ivan Izobov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please
click onthe(^) Previewtab and select the appropriate sub-template: