Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not showing appropriate stack trace or file location with Rails 5.1 #371

Closed
niedfelj opened this issue May 1, 2017 · 12 comments
Closed
Labels
Milestone

Comments

@niedfelj
Copy link

niedfelj commented May 1, 2017

Not sure what's going on here, but an example putting <%= hi %> in a template in 5.0:

screen shot 2017-05-01 at 3 33 17 pm

And in 5.1:

screen shot 2017-05-01 at 3 32 19 pm

@niedfelj
Copy link
Author

niedfelj commented May 1, 2017

It seems to be limited to errors in templates/render code

@niedfelj
Copy link
Author

niedfelj commented May 3, 2017

@charliesome Are you still maintaining this?

@kobaltz
Copy link

kobaltz commented May 16, 2017

I noticed this as well and confirmed it's still an issue in Ruby on Rails 5.1.1

@niedfelj
Copy link
Author

@kobaltz I was going to try to fix this today, and then when I did a checkout and local bundle config, it started working...very strange, but I've tested in a new rails 5.1.1 project in addition and switched back and forth between published gem and the git/master branch and can confirm that using the git method in the Gemfile seems to make it work. Can you confirm also?

  gem 'binding_of_caller'
  gem 'better_errors', git: 'https://github.com/charliesome/better_errors.git', branch: 'master'

I even tried using the published better_errors.gemspec for 2.1.1 in a local checkout (that was the only file that was different) and it still worked, so maybe this is a bundler issue?

Here's my local setup:

ruby 2.4.1
rails 5.1.1
bundler 1.14.6
rubygems 2.6.11
mac os 10.12.4

@kobaltz
Copy link

kobaltz commented May 19, 2017

@niedfelj It did work with the https://github.com/charliesome/better_errors source. Thanks.

@dsfernandobond
Copy link

Had the same problem, using https://github.com/charliesome/better_errors fixed it for me too thanks.

@inopinatus
Copy link

Thanks! This was making debugging of partials really painful.

@rept
Copy link

rept commented Jul 3, 2017

Working now with master branch!

@RobinDaugherty
Copy link
Member

Sounds like this was fixed by #354. New release of the gem will be coming soon.

@RobinDaugherty
Copy link
Member

Version 2.2.0 of the gem has been released, so this issue seems to be fixed.

@paneq
Copy link

paneq commented May 24, 2018

Not fixed for me unfortunately :(

  • rails 5.0.6
  • ruby 2.5.1p57

@RobinDaugherty
Copy link
Member

@paneq @golddiga this issue was for Rails 5.1. Rails 5.0 hasn't had this issue reported. But in my testing with Rails 5.0.6 on Ruby 2.5.1 and an ERB template, I'm getting the correct location. Can you open a new issue with some more information on how to reproduce your issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants