Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Gem works differently depending on source (rubygems,git) #5666

Closed
niedfelj opened this issue May 16, 2017 · 4 comments
Closed

Gem works differently depending on source (rubygems,git) #5666

niedfelj opened this issue May 16, 2017 · 4 comments

Comments

@niedfelj
Copy link

The better_errors gem on rails 5.1.1, ruby 2.4.1, bundler 1.14.6 appears to behave differently depending on if it is loaded using

gem 'better_errors'

vs

gem 'better_errors', git: 'https://github.com/charliesome/better_errors.git', branch: 'master'

Even if they are EXACTLY the same.

More details here

BetterErrors/better_errors#371

Wondering if you guys have any insight into why?

@segiddins
Copy link
Member

Can you please share a project we can use to reproduce the discrepancy? Thanks!

@niedfelj
Copy link
Author

@segiddins Sure!

https://github.com/niedfelj/rails_51_better_errors

Try running that, changing from the git version of better_errors and the rubygems version. You can hit localhost:3000/test to throw an error. It should show the template location and proper stack trace if you are using the git version.

@segiddins
Copy link
Member

If I point using git to the v2.1.1 tag, the issue with the released gem shows up, so my guess is this is just a bug that they've fixed on master since the release of v2.1.1

@niedfelj
Copy link
Author

Interesting. When I diffed the gem locally with my checkout, they appeared the same, but you're right that the diff does show changes here

BetterErrors/better_errors@v2.1.1...master

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants