Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert BetterErrors rack middleware after ActionDispatch::DebugExceptions in the railtie #104

Merged
merged 2 commits into from
Feb 1, 2013
Merged

Conversation

loopj
Copy link
Contributor

@loopj loopj commented Jan 29, 2013

Insert BetterErrors::Middleware Rack middleware after ActionDispatch::DebugExceptions in the Rails railtie.

There are multiple reasons for moving the middleware position:

  • Better Errors will work even for exceptions thrown from rack middlewares (actiondispatch etc)
  • Other error monitoring services (eg. Bugsnag) will still be called before showing the Better Errors page
  • Being a good Rack citizen ;)

This change should be backward compatible.

@haileys
Copy link
Collaborator

haileys commented Jan 29, 2013

lgtm, i'll check it out properly tonight

@loopj
Copy link
Contributor Author

loopj commented Jan 29, 2013

Thanks @charliesome .

haileys pushed a commit that referenced this pull request Feb 1, 2013
Insert BetterErrors rack middleware after ActionDispatch::DebugExceptions in the railtie
@haileys haileys merged commit 9037c49 into BetterErrors:master Feb 1, 2013
@haileys
Copy link
Collaborator

haileys commented Feb 1, 2013

Sorry for the delay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants