Command History #15
Merged
Command History #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, I got motivated and did it myself! Hope it's up to scratch, it seems to work! |
| @@ -276,6 +276,9 @@ | |||
| var header = document.querySelector("header"); | |||
| var headerHeight = header.offsetHeight; | |||
|
|
|||
| var previousCommands = new Array(); | |||
| } | ||
| // now set the input's text to the previous command | ||
| // in the list. | ||
| input.value = previousCommand; |
There was a problem hiding this comment.
Hey, this is awesome! After this line, could you please use something like this to set the cursor at the end of the text? (It's not happening for me in Chrome, otherwise.)
|
This works pretty well, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pressing up and down on the keyboard will move through the user's command history like it does on a standard command line.