Consolidate newlines in exception messages to avoid blank output #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exception message will now have leading newlines removed to avoid displaying a blank message as a header.
latortuga
force-pushed
the
strip-leading-space
branch
from
af0b001 to
a65b56d
Compare
|
👍 |
rstacruz
added a commit
that referenced
this pull request
Dec 3, 2015
Consolidate newlines in exception messages to avoid blank output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exception message will now have leading newlines removed to avoid displaying a blank message as a header.
I took the way the error message is constructed from ActiveRecord's MigrationError error class and wrote a test case mimicking it.
Fixes #313