Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Rails BacktraceCleaner to log errors if it's defined #343

Merged
merged 1 commit into from
Aug 26, 2017

Conversation

pzgz
Copy link
Contributor

@pzgz pzgz commented Apr 15, 2016

After installed better_errors gem in Rails app, the settings in backtrace cleaner won't work in the console. Issue #308 was talked about this.

Tried to introduce Rails BacktraceCleaner if possible.

@rstacruz
Copy link
Collaborator

looks okay to me, but i haven't been involved in this project for a long time, i'm not too confident about merging it!

@RobinDaugherty RobinDaugherty modified the milestones: v2.3, v2.4 Jul 29, 2017
@RobinDaugherty RobinDaugherty changed the title Try to respect Rails BacktraceCleaner if it's defined Use Rails BacktraceCleaner to log errors if it's defined Aug 26, 2017
@RobinDaugherty RobinDaugherty merged commit beed186 into BetterErrors:master Aug 26, 2017
RobinDaugherty added a commit that referenced this pull request Aug 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants