Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from erubis to erubi #390

Merged

Conversation

RobinDaugherty
Copy link
Member

Rails has switched to erubi for what seem like good reasons:

  • Works with Ruby's --enable-frozen-string-literal option
  • Has 88% smaller memory footprint
  • Does no freedom patching (Erubis adds a method to Kernel)
  • Has simpler internals (1 file, <150 lines of code)
  • Has an open development model (Erubis doesn't have a public source control repository or bug tracker)
  • Is not dead (Erubis hasn't been updated since 2011)

Since Rails has switched, switching the dependency in Better Errors means one fewer dependency for most users. There doesn't seem to be any downside.

This completes #377.

@RobinDaugherty RobinDaugherty added this to the v2.3 milestone Jul 31, 2017
@RobinDaugherty RobinDaugherty merged commit 9da99cc into BetterErrors:master Aug 3, 2017
@RobinDaugherty RobinDaugherty deleted the feature/switch-to-erubi branch August 3, 2017 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant