Ruby and Rails matrix in CI #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and move build-specific dependencies to the Appraisals.
It seems travis doesn't use the latest of each version specified, even though rvm does. rvm/rvm#3512 (comment)
RobinDaugherty
force-pushed
the
feature/test-matrix
branch
from
07ee1b0 to
428ab0a
Compare
We have to customize nokogiri version based on ruby version, and Appraisal doesn't support that. We'll have to maintain the gemfiles manually.
RobinDaugherty
force-pushed
the
feature/test-matrix
branch
from
428ab0a to
c8a6170
Compare
RobinDaugherty
force-pushed
the
feature/test-matrix
branch
from
c8a6170 to
745712b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A gemfile for each set of dependencies that Better Errors intends to support. These are:
Added these to Travis config, matrixed with each major version of MRI. Turns out that, for example, "2.4" does not mean "the latest 2.4", so I had to change the Ruby versions in Travis to the latest minor release of each.
At this time, Pry 0.10 does not pass specs. This is a real issue with Pry 0.10 that will need to be resolved. It's in the
allowed_failuresbecause of this.