Rescue on undefined local variables in frame_binding #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, I see errors on local variables: `m`, `args`, `block`, `r`, and `target` when inspecting an error on a class that inherits from SimpleDelegator. Fix: Add a rescue on NameError to catch these. Fixes issue: #351 Inspiration for this fix comes from @glebtv in glebtv@6d00365
|
Thanks for your contribution! Do you think you could add a test that covers this? |
|
Yes, I will give it a shot! Thanks. |
|
@RobinDaugherty done. I added the tests as a fixup commit. I'm assuming you'll do a squash and merge if accepted. But let me know if I can do anything else. Thanks for your work on this excellent gem! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some local variables appear to be undefined in the frame_binding.
For example, I see errors on local variables:
m,args,block,r, andtargetwhen inspecting an error on a class that inherits from SimpleDelegator.Fix: Add a rescue on NameError to catch these.
Fixes issue: #351
Inspiration for this fix comes from @glebtv in glebtv@6d00365
Example: