Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify older kramdown and i18n for older ruby versions #437

Merged
merged 2 commits into from
Jul 9, 2019

Conversation

RobinDaugherty
Copy link
Member

@RobinDaugherty RobinDaugherty commented Feb 14, 2019

CI failure was caused by kramdown 2.0+ requiring Ruby 2.3+. This fixes it by specifying the older kramdown version when the current Ruby version is older than 2.3.

Same for i18n 1.5.2, which is a dependency of Rails, not a development dependency.

CI failure was caused by kramdown 2.0 requiring Ruby 2.3+.
@RobinDaugherty RobinDaugherty force-pushed the fix/kramdown-ruby-dependency branch from 1a132c5 to a331158 Compare February 14, 2019 20:09
@RobinDaugherty RobinDaugherty changed the title Specify older kramdown for older ruby versions Specify older kramdown and i18n for older ruby versions Feb 14, 2019
@RobinDaugherty RobinDaugherty merged commit 34df3eb into master Jul 9, 2019
@RobinDaugherty RobinDaugherty deleted the fix/kramdown-ruby-dependency branch July 9, 2019 03:45
@RobinDaugherty RobinDaugherty added this to the v2.6 milestone Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant