Merge pull request #59 from joshhjacobson/feature/fix-flipAxes

Enable programmatic use of flipAxes(), address #50
BigFatDog · Jan 15, 2019 · ecde298 · ecde298
2 parents 70c1679 + bce4ad1
commit ecde298
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 4 deletions.
diff --git a/src/bindEvents.js b/src/bindEvents.js
@@ -30,6 +30,7 @@ const bindEvents = (
     ctx,
     pc,
     xscale,
+    axis,
     flags,
     brushedQueue,
     markedQueue,

diff --git a/src/state/sideEffects.js b/src/state/sideEffects.js
@@ -15,6 +15,7 @@ const sideEffects = (
   ctx,
   pc,
   xscale,
+  axis,
   flags,
   brushedQueue,
   markedQueue,
@@ -76,8 +77,8 @@ const sideEffects = (
     })
     .on('flipAxes', d => {
       if (d.value && d.value.length) {
-        d.value.forEach(function(axis) {
-          flipAxisAndUpdatePCP(config, pc, axis);
+        d.value.forEach(function(dimension) {
+          flipAxisAndUpdatePCP(config, pc, axis)(dimension);
         });
         pc.updateAxes(0);
       }

diff --git a/src/util/flipAxisAndUpdatePCP.js b/src/util/flipAxisAndUpdatePCP.js
@@ -1,10 +1,15 @@
-import { select } from 'd3-selection';
+import { select, selectAll } from 'd3-selection';
 
 const flipAxisAndUpdatePCP = (config, pc, axis) =>
   function(dimension) {
     pc.flip(dimension);
     pc.brushReset(dimension);
-    select(this.parentElement)
+
+    // select(this.parentElement)
+    pc.selection
+      .select('svg')
+      .selectAll('g.axis')
+      .filter(d => d === dimension)
       .transition()
       .duration(config.animationTime)
       .call(axis.scale(config.dimensions[dimension].yscale));
-Original file line number
+Diff line change
@@ Expand Up / @@ -30,6 +30,7 @@ const bindEvents = ( @@
         ctx,
         pc,
         xscale,
+        axis,
         flags,
         brushedQueue,
         markedQueue,
@@ Expand Down @@