import sylvester, closes #51 #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigFatDog
reviewed
Dec 28, 2018
src/util/computeCentroids.js
Outdated
| @@ -32,7 +35,8 @@ const computeCentroids = (config, position, row) => { | |||
| let centroid = 0.5 * (leftCentroid + rightCentroid); | |||
| cy = centroid + (1 - config.bundlingStrength) * (cy - centroid); | |||
| } | |||
| centroids.push($V([cx, cy])); | |||
| v = new Vector([cx, cy]); | |||
There was a problem hiding this comment.
Suggested change
| v = new Vector([cx, cy]); |
BigFatDog
reviewed
Dec 28, 2018
src/util/computeCentroids.js
Outdated
| @@ -32,7 +35,8 @@ const computeCentroids = (config, position, row) => { | |||
| let centroid = 0.5 * (leftCentroid + rightCentroid); | |||
| cy = centroid + (1 - config.bundlingStrength) * (cy - centroid); | |||
| } | |||
| centroids.push($V([cx, cy])); | |||
| v = new Vector([cx, cy]); | |||
| centroids.push(v); | |||
There was a problem hiding this comment.
Suggested change
| centroids.push(v); | |
| centroids.push(new Vector([cx, cy])); |
BigFatDog
reviewed
Dec 28, 2018
src/util/computeCentroids.js
Outdated
| @@ -8,7 +10,8 @@ const computeCentroids = (config, position, row) => { | |||
| // centroids on 'real' axes | |||
| const x = position(p[i]); | |||
| const y = config.dimensions[p[i]].yscale(row[p[i]]); | |||
| centroids.push($V([x, y])); | |||
| let v = new Vector([x, y]); | |||
There was a problem hiding this comment.
Suggested change
| let v = new Vector([x, y]); |
BigFatDog
reviewed
Dec 28, 2018
src/util/computeCentroids.js
Outdated
| @@ -8,7 +10,8 @@ const computeCentroids = (config, position, row) => { | |||
| // centroids on 'real' axes | |||
| const x = position(p[i]); | |||
| const y = config.dimensions[p[i]].yscale(row[p[i]]); | |||
| centroids.push($V([x, y])); | |||
| let v = new Vector([x, y]); | |||
| centroids.push(v); | |||
There was a problem hiding this comment.
Suggested change
| centroids.push(v); | |
| centroids.push(new Vector([cx, cy])); |
BigFatDog
reviewed
Dec 28, 2018
src/util/computeControlPoints.js
Outdated
| centroids[0].e(2), | ||
| ]) | ||
| ); | ||
| cps.push(v); |
There was a problem hiding this comment.
variable v is not used afterwards, we may consider adding it directly:
cps.push(new Vector(...))
There was a problem hiding this comment.
I didn't realize it's possible to instantiate a class inside a function call, thanks for catching that! I've made the changes and pushed them in a new commit. Please let me know if there's anything else.
|
Thank you for this PR! 🎄 🎄 🎄 I've gone through your code and left my comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.